Closed Bug 1816824 Opened 3 years ago Closed 3 years ago

Create tests for more main menus, and fix code that tests have found to be broken

Categories

(Thunderbird :: Mail Window Front End, task)

Product:
Thunderbird
Component:
Mail Window Front End
Version:
Thunderbird 111
Platform:
Unspecified
All
Type:
task

Tracking

(thunderbird_esr102 unaffected, thunderbird111 fixed)

Status:
RESOLVED FIXED
Milestone:
112 Branch
Tracking Flags:
Tracking Status
thunderbird_esr102 --- unaffected
thunderbird111 --- fixed

People

(Reporter: darktrojan, Assigned: darktrojan)

References

Details

(Keywords: leave-open, Whiteboard: [Supernova3p])

Attachments

(6 files, 1 obsolete file)

Bug 1816824 - Test Edit menu item states. r=#thunderbird-reviewers
48 bytes, text/x-phabricator-request
wsmwk
: approval-comm-beta+
Details | Review
Bug 1816824 - Test View menu item states. r=#thunderbird-reviewers
48 bytes, text/x-phabricator-request
wsmwk
: approval-comm-beta+
Details | Review
Bug 1816824 - Test Go menu item states. r=#thunderbird-reviewers
48 bytes, text/x-phabricator-request
wsmwk
: approval-comm-beta+
Details | Review
Bug 1816824 - Add new Folder Pane Header menu item to view menu test. r=#thunderbird-reviewers
48 bytes, text/x-phabricator-request
wsmwk
: approval-comm-beta+
Details | Review
Bug 1816824 - Test Message menu item states. r=#thunderbird-reviewers
48 bytes, text/x-phabricator-request
wsmwk
: approval-comm-beta+
Details | Review
Bug 1816824 - Test Tools menu item states. r=#thunderbird-reviewers
48 bytes, text/x-phabricator-request
wsmwk
: approval-comm-beta+
Details | Review

Using the framework I set up to test the File menu in bug 1814322, I'm going to test the other menus. For now I'm just going to do the basic functionality so that I can get the patches landed and out of my way.

Pushed by geoff@darktrojan.net: https://hg.mozilla.org/comm-central/rev/658f3bfac789 Test Edit menu item states. r=mkmelin https://hg.mozilla.org/comm-central/rev/6f47c9c426b0 Test Go menu item states. r=mkmelin
Pushed by geoff@darktrojan.net: https://hg.mozilla.org/comm-central/rev/114d9cd1e98a Test View menu item states. r=mkmelin
Attachment #9317834 - Attachment is obsolete: true
Regressions: 1817060
Pushed by geoff@darktrojan.net: https://hg.mozilla.org/comm-central/rev/9748153a2a73 Add new Folder Pane Header menu item to view menu test. r=aleca

Comment on attachment 9317776 [details]
Bug 1816824 - Test Edit menu item states. r=#thunderbird-reviewers

[Approval Request Comment]
Regression caused by (bug #): Supernova

Attachment #9317776 - Flags: approval-comm-beta?

Comment on attachment 9317777 [details]
Bug 1816824 - Test View menu item states. r=#thunderbird-reviewers

[Approval Request Comment]
Regression caused by (bug #): Supernova

Attachment #9317777 - Flags: approval-comm-beta?

Comment on attachment 9317778 [details]
Bug 1816824 - Test Go menu item states. r=#thunderbird-reviewers

[Approval Request Comment]
Regression caused by (bug #): Supernova

Attachment #9317778 - Flags: approval-comm-beta?

Comment on attachment 9317990 [details]
Bug 1816824 - Add new Folder Pane Header menu item to view menu test. r=#thunderbird-reviewers

[Approval Request Comment]
Regression caused by (bug #): Supernova

Attachment #9317990 - Flags: approval-comm-beta?

Comment on attachment 9317776 [details]
Bug 1816824 - Test Edit menu item states. r=#thunderbird-reviewers

[Triage Comment]
Approved for beta

Attachment #9317776 - Flags: approval-comm-beta? → approval-comm-beta+

Comment on attachment 9317777 [details]
Bug 1816824 - Test View menu item states. r=#thunderbird-reviewers

[Triage Comment]
Approved for beta

Attachment #9317777 - Flags: approval-comm-beta? → approval-comm-beta+

Comment on attachment 9317778 [details]
Bug 1816824 - Test Go menu item states. r=#thunderbird-reviewers

[Triage Comment]
Approved for beta

Attachment #9317778 - Flags: approval-comm-beta? → approval-comm-beta+

Comment on attachment 9317990 [details]
Bug 1816824 - Add new Folder Pane Header menu item to view menu test. r=#thunderbird-reviewers

[Triage Comment]
Approved for beta

Attachment #9317990 - Flags: approval-comm-beta? → approval-comm-beta+
See Also: → 1819005
Whiteboard: [Supernova]
Keywords: checkin-needed-tb

Pushed by mkmelin@iki.fi:
https://hg.mozilla.org/comm-central/rev/7b9476ad8c01
Test Message menu item states. r=mkmelin
https://hg.mozilla.org/comm-central/rev/32497e7146ca
Test Tools menu item states. r=mkmelin

Keywords: checkin-needed-tb
Attachment #9321492 - Flags: approval-comm-beta?
Attachment #9321494 - Flags: approval-comm-beta?

Resetting to affected so that queries pick up the latest patches. (Which, BTW, aren't just tests, a bunch of issues were picked up by the tests and fixed.)

status-thunderbird111: fixed → affected
OS: Unspecified → All
Summary: Create tests for more main menus → Create tests for more main menus, and fix code that tests have found to be broken
Version: unspecified → Thunderbird 111

Comment on attachment 9321494 [details]
Bug 1816824 - Test Tools menu item states. r=#thunderbird-reviewers

[Triage Comment]
Approved for beta

Attachment #9321494 - Flags: approval-comm-beta? → approval-comm-beta+

Comment on attachment 9321492 [details]
Bug 1816824 - Test Message menu item states. r=#thunderbird-reviewers

[Triage Comment]
Approved for beta

Attachment #9321492 - Flags: approval-comm-beta? → approval-comm-beta+
Status: ASSIGNED → RESOLVED
Closed: 3 years ago
Resolution: --- → FIXED
Regressions: 1826744
Whiteboard: [Supernova] → [Supernova3p]
Regressions: 2056286
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: