1816859 - Picture-in-Picture button overlaps volume slider on reddit.com

Status: VERIFIED FIXED

(Toolkit :: Picture-in-Picture, defect, P3)

Description

[nicoleta.sibisan]

Attachment: PIP overlaps volume slider on reddit

Found in

• 110.0b9

Affected versions

• 101.0, 102.8.0esr, 110.0b9, 111.0a1

Tested platforms

• Affected platforms: Mac 12.5, Win 10, Ubuntu 20

Steps to reproduce

1. Go to
   https://www.reddit.com/r/OldSchoolCool/comments/10jbjbn/the_cranberries_dolores_oriordan_linger_making/
2. Play the video
3. Hover over the volume button to pop up a slider.
4. Try clicking the volume slider "Thumb" at various intermediate positions.

Expected result

• PIP icon moves so it doesn't overlap with the volume slider.

Actual result

• The PiP icon overlaps the popped up volume slider.
• If you have the slider at just the right spot where it slightly overlaps the PiP icon, you can accidentally trigger PiP when you click the edge of the volume slider.
• If you hover the intersection area where the two icons overlap, both icons brighten as if they're hovered, even though in fact your click only gets received by the PiP icon.

Regression range

• Not a recent regression since I have been able to reproduce this issue in Fx 101.0

Comment 1

[Bilal]

Attachment: Bug 1816859 - Adjusted visibility for PiP toggle on Reddit. r?kpatenio

Comment 2

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/954ebee9baae
Adjusted visibility for PiP toggle on Reddit. r=kpatenio,desktop-theme-reviewers,pip-reviewers

Comment 3

[Marian-Vasile Laza]

Backed out changeset 954ebee9baae (Bug 1816859) for bc failures on browser_togglePolicies.js.
Backout link
Push with failures <--> bc12
Failure Log

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/a66c20b8af84
Adjusted visibility for PiP toggle on Reddit. r=kpatenio,desktop-theme-reviewers,pip-reviewers

Comment 5

[Bilal]

Should be alright now.

Comment 6

[Marian-Vasile Laza]

https://hg.mozilla.org/mozilla-central/rev/a66c20b8af84

Comment 7

[nicoleta.sibisan]

Verified - fixed in Nightly 113.0a1 (2023-03-21), on MacOs 12, Win 11 and Ubuntu 22.