1816901 - Stop using promiseItemId in product code

Status: RESOLVED FIXED

(Toolkit :: Places, task, P3)

Description

[Marco Bonardo [:mak]]

promiseItemGUID is only used in testing code, it should be possible to do the same for promiseItemId, with some small refactoring of gEditItemOverlay and using RETURNING on some queries.

What'd be left then is promiseManyItemIds, before the whole GuidHelper can be moved to testing code. that may likely also be removed with some changes to Bookmarks.jsm (it's unlikely we can completely remove itemIds but at least we could fetch them while we fetch other data).

Comment 1

[Marco Bonardo [:mak]]

Attachment: Bug 1816901 - Stop using promiseItemId in product code. r=daisuke

Comment 2

[Marco Bonardo [:mak]]

Attachment: Bug 1816901 - Stop using promiseManyItemdIds in product code. r=daisuke

Depends on D180410

Comment 3

[Marco Bonardo [:mak]]

Attachment: Bug 1816901 - Remove the Places GuidHelper. r=daisuke

Depends on D180411

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/3589e6b5cd09
Stop using promiseItemId in product code. r=daisuke
https://hg.mozilla.org/integration/autoland/rev/47c72bd9e7ec
Stop using promiseManyItemdIds in product code. r=daisuke
https://hg.mozilla.org/integration/autoland/rev/c07120b42e96
Remove the Places GuidHelper. r=daisuke,sync-reviewers,skhamis

Comment 5

[Cristian Tuns]

https://hg.mozilla.org/mozilla-central/rev/3589e6b5cd09
https://hg.mozilla.org/mozilla-central/rev/47c72bd9e7ec
https://hg.mozilla.org/mozilla-central/rev/c07120b42e96