Closed
Bug 1829579
Opened 2 years ago
Closed 2 years ago
Remove nsNavHistory::BookmarkIdToResultNode()
Categories
(Toolkit :: Places, task, P3)
Toolkit
Places
Tracking
()
RESOLVED
FIXED
116 Branch
| Tracking | Status | |
|---|---|---|
| firefox116 | --- | fixed |
People
(Reporter: daisuke, Assigned: daisuke)
References
Details
(Whiteboard: [snt-scrubbed] [places-papercut])
Attachments
(1 file)
No description provided.
|
Assignee | |
Updated•2 years ago
|
Summary: Remove BookmarkIdToResultNode → Remove nsNavHistory::BookmarkIdToResultNode()
|
||
Updated•2 years ago
|
See Also: → https://mozilla-hub.atlassian.net/browse/SNT-645
|
||
Updated•2 years ago
|
Severity: -- → N/A
Priority: -- → P3
|
|
||
Updated•2 years ago
|
Whiteboard: [snt-scrubbed] [places-papercut]
|
|
Assignee | |
Comment 1•2 years ago
|
||
Pushed by dakatsuka.birchill@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/1d7787405985
Remove nsNavHistory::BookmarkIdToResultNode() r=mak
|
||
Comment 3•2 years ago
|
||
Backed out for causing sanitizer failures on nsNavHistoryResult.cpp
- backout: https://hg.mozilla.org/integration/autoland/rev/edef1940a6bd4d95b235e43b1cada493f561f78a
- push: https://treeherder.mozilla.org/jobs?repo=autoland&revision=1d7787405985e0804ee3e4f4187777dfad6fdd2d&group_state=expanded
- failure log: https://treeherder.mozilla.org/logviewer?job_id=419900142&repo=autoland&lineNumber=3900
[task 2023-06-19T22:57:36.646Z] 22:57:36 INFO - TEST-PASS | toolkit/components/places/tests/unit/test_tagging.js | run_test - [run_test : 22] 0 == 0
[task 2023-06-19T22:57:36.646Z] 22:57:36 INFO - PID 21292 | /builds/worker/checkouts/gecko/toolkit/components/places/nsNavHistoryResult.cpp:4243:9: runtime error: load of value 228, which is not a valid value for type 'bool'
[task 2023-06-19T22:57:36.646Z] 22:57:36 INFO - PID 21292 | #0 0x7fe96368f032 in nsNavHistoryResult::HandlePlacesEvent(mozilla::dom::Sequence<mozilla::OwningNonNull<mozilla::dom::PlacesEvent>> const&) /builds/worker/checkouts/gecko/toolkit/components/places/nsNavHistoryResult.cpp:4243:9
[task 2023-06-19T22:57:36.646Z] 22:57:36 INFO - PID 21292 | #1 0x7fe95725ff88 in operator() /builds/worker/fetches/sysroot-x86_64-linux-gnu/usr/lib/gcc/x86_64-linux-gnu/8/../../../../include/c++/8/bits/std_function.h:687:14
[task 2023-06-19T22:57:36.647Z] 22:57:36 INFO - PID 21292 | #2 0x7fe95725ff88 in void mozilla::dom::CallListeners<mozilla::WeakPtr<mozilla::places::INativePlacesEventCallback, (mozilla::detail::WeakPtrDestructorBehavior)0>, RefPtr<mozilla::places::INativePlacesEventCallback>, mozilla::dom::ListenerCollection<mozilla::WeakPtr<mozilla::places::INativePlacesEventCallback, (mozilla::detail::WeakPtrDestructorBehavior)0>>>(unsigned int, mozilla::dom::Sequence<mozilla::OwningNonNull<mozilla::dom::PlacesEvent>> const&, unsigned long, std::function<RefPtr<mozilla::places::INativePlacesEventCallback> (mozilla::WeakPtr<mozilla::places::INativePlacesEventCallback, (mozilla::detail::WeakPtrDestructorBehavior)0>&)> const&, std::function<void (RefPtr<mozilla::places::INativePlacesEventCallback>&, mozilla::dom::Sequence<mozilla::OwningNonNull<mozilla::dom::PlacesEvent>> const&)> const&) /builds/worker/checkouts/gecko/dom/base/PlacesObservers.cpp:112:7
[task 2023-06-19T22:57:36.647Z] 22:57:36 INFO - PID 21292 | #3 0x7fe95725e6cc in mozilla::dom::PlacesObservers::NotifyNext() /builds/worker/checkouts/gecko/dom/base/PlacesObservers.cpp:350:3
[task 2023-06-19T22:57:36.647Z] 22:57:36 INFO - PID 21292 | #4 0x7fe96361053b in nsNavBookmarks::CreateFolder(long, nsTSubstring<char> const&, int, nsTSubstring<char> const&, unsigned short, long*) /builds/worker/checkouts/gecko/toolkit/components/places/nsNavBookmarks.cpp:667:5
[task 2023-06-19T22:57:36.647Z] 22:57:36 INFO - PID 21292 | #5 0x7fe9539822c5 in NS_InvokeByIndex /builds/worker/checkouts/gecko/xpcom/reflect/xptcall/md/unix/xptcinvoke_asm_x86_64_unix.S:101
[task 2023-06-19T22:57:36.647Z] 22:57:36 INFO - PID 21292 | #6 0x7fe9556f72a6 in Invoke /builds/worker/checkouts/gecko/js/xpconnect/src/XPCWrappedNative.cpp:1627:10
[task 2023-06-19T22:57:36.647Z] 22:57:36 INFO - PID 21292 | #7 0x7fe9556f72a6 in Call /builds/worker/checkouts/gecko/js/xpconnect/src/XPCWrappedNative.cpp:1180:19
[task 2023-06-19T22:57:36.647Z] 22:57:36 INFO - PID 21292 | #8 0x7fe9556f72a6 in XPCWrappedNative::CallMethod(XPCCallContext&, XPCWrappedNative::CallMode) /builds/worker/checkouts/gecko/js/xpconnect/src/XPCWrappedNative.cpp:1126:23
[task 2023-06-19T22:57:36.647Z] 22:57:36 INFO - PID 21292 | #9 0x7fe9556fcd86 in XPC_WN_CallMethod(JSContext*, unsigned int, JS::Value*) /builds/worker/checkouts/gecko/js/xpconnect/src/XPCWrappedNativeJSOps.cpp:966:10
[task 2023-06-19T22:57:36.647Z] 22:57:36 INFO - PID 21292 | #10 0x7fe963fe9973 in CallJSNative /builds/worker/checkouts/gecko/js/src/vm/Interpreter.cpp:486:13
[task 2023-06-19T22:57:36.647Z] 22:57:36 INFO - PID 21292 | #11 0x7fe963fe9973 in js::InternalCallOrConstruct(JSContext*, JS::CallArgs const&, js::MaybeConstruct, js::CallReason) /builds/worker/checkouts/gecko/js/src/vm/Interpreter.cpp:580:12
[task 2023-06-19T22:57:36.647Z] 22:57:36 INFO - PID 21292 | #12 0x7fe96400e5e1 in InternalCall /builds/worker/checkouts/gecko/js/src/vm/Interpreter.cpp:647:10
[task 2023-06-19T22:57:36.647Z] 22:57:36 INFO - PID 21292 | #13 0x7fe96400e5e1 in CallFromStack /builds/worker/checkouts/gecko/js/src/vm/Interpreter.cpp:652:10
[task 2023-06-19T22:57:36.647Z] 22:57:36 INFO - PID 21292 | #14 0x7fe96400e5e1 in js::Interpret(JSContext*, js::RunState&) /builds/worker/checkouts/gecko/js/src/vm/Interpreter.cpp:3395:16
[task 2023-06-19T22:57:36.647Z] 22:57:36 INFO - PID 21292 | #15 0x7fe963fe86eb in MaybeEnterInterpreterTrampoline /builds/worker/checkouts/gecko/js/src/vm/Interpreter.cpp:400:10
[task 2023-06-19T22:57:36.647Z] 22:57:36 INFO - PID 21292 | #16 0x7fe963fe86eb in js::RunScript(JSContext*, js::RunState&) /builds/worker/checkouts/gecko/js/src/vm/Interpreter.cpp:458:13
[task 2023-06-19T22:57:36.647Z] 22:57:36 INFO - PID 21292 | #17 0x7fe963fe9b2c in js::InternalCallOrConstruct(JSContext*, JS::CallArgs const&, js::MaybeConstruct, js::CallReason) /builds/worker/checkouts/gecko/js/src/vm/Interpreter.cpp:612:13
[task 2023-06-19T22:57:36.647Z] 22:57:36 INFO - PID 21292 | #18 0x7fe963febaa6 in InternalCall /builds/worker/checkouts/gecko/js/src/vm/Interpreter.cpp:647:10
[task 2023-06-19T22:57:36.647Z] 22:57:36 INFO - PID 21292 | #19 0x7fe963febaa6 in js::Call(JSContext*, JS::Handle<JS::Value>, JS::Handle<JS::Value>, js::AnyInvokeArgs const&, JS::MutableHandle<JS::Value>, js::CallReason) /builds/worker/checkouts/gecko/js/src/vm/Interpreter.cpp:679:8
[task 2023-06-19T22:57:36.647Z] 22:57:36 INFO - PID 21292 | #20 0x7fe96413c3d2 in JS_CallFunctionValue(JSContext*, JS::Handle<JSObject*>, JS::Handle<JS::Value>, JS::HandleValueArray const&, JS::MutableHandle<JS::Value>) /builds/worker/checkouts/gecko/js/src/vm/CallAndConstruct.cpp:53:10
[task 2023-06-19T22:57:36.647Z] 22:57:36 INFO - PID 21292 | #21 0x7fe9556e58dd in nsXPCWrappedJS::CallMethod(unsigned short, nsXPTMethodInfo const*, nsXPTCMiniVariant*) /builds/worker/checkouts/gecko/js/xpconnect/src/XPCWrappedJSClass.cpp:918:17
[task 2023-06-19T22:57:36.647Z] 22:57:36 INFO - PID 21292 | #22 0x7fe953983ce9 in PrepareAndDispatch /builds/worker/checkouts/gecko/xpcom/reflect/xptcall/md/unix/xptcstubs_x86_64_linux.cpp:115:37
[task 2023-06-19T22:57:36.647Z] 22:57:36 INFO - PID 21292 | #23 0x7fe9539829ea in SharedStub xptcstubs_x86_64_linux.cpp
[task 2023-06-19T22:57:36.647Z] 22:57:36 INFO - PID 21292 | #24 0x7fe9539822c5 in NS_InvokeByIndex /builds/worker/checkouts/gecko/xpcom/reflect/xptcall/md/unix/xptcinvoke_asm_x86_64_unix.S:101
[task 2023-06-19T22:57:36.647Z] 22:57:36 INFO - PID 21292 | #25 0x7fe9556f72a6 in Invoke /builds/worker/checkouts/gecko/js/xpconnect/src/XPCWrappedNative.cpp:1627:10
[task 2023-06-19T22:57:36.648Z] 22:57:36 INFO - PID 21292 | #26 0x7fe9556f72a6 in Call /builds/worker/checkouts/gecko/js/xpconnect/src/XPCWrappedNative.cpp:1180:19
[task 2023-06-19T22:57:36.648Z] 22:57:36 INFO - PID 21292 | #27 0x7fe9556f72a6 in XPCWrappedNative::CallMethod(XPCCallContext&, XPCWrappedNative::CallMode) /builds/worker/checkouts/gecko/js/xpconnect/src/XPCWrappedNative.cpp:1126:23
[task 2023-06-19T22:57:36.649Z] 22:57:36 INFO - PID 21292 | #28 0x7fe9556fcd86 in XPC_WN_CallMethod(JSContext*, unsigned int, JS::Value*) /builds/worker/checkouts/gecko/js/xpconnect/src/XPCWrappedNativeJSOps.cpp:966:10
[task 2023-06-19T22:57:36.649Z] 22:57:36 INFO - PID 21292 | #29 0x7fe963fe9973 in CallJSNative /builds/worker/checkouts/gecko/js/src/vm/Interpreter.cpp:486:13
[task 2023-06-19T22:57:36.649Z] 22:57:36 INFO - PID 21292 | #30 0x7fe963fe9973 in js::InternalCallOrConstruct(JSContext*, JS::CallArgs const&, js::MaybeConstruct, js::CallReason) /builds/worker/checkouts/gecko/js/src/vm/Interpreter.cpp:580:12
[task 2023-06-19T22:57:36.650Z] 22:57:36 INFO - PID 21292 | #31 0x7fe96400e5e1 in InternalCall /builds/worker/checkouts/gecko/js/src/vm/Interpreter.cpp:647:10
[task 2023-06-19T22:57:36.650Z] 22:57:36 INFO - PID 21292 | #32 0x7fe96400e5e1 in CallFromStack /builds/worker/checkouts/gecko/js/src/vm/Interpreter.cpp:652:10
[task 2023-06-19T22:57:36.651Z] 22:57:36 INFO - PID 21292 | #33 0x7fe96400e5e1 in js::Interpret(JSContext*, js::RunState&) /builds/worker/checkouts/gecko/js/src/vm/Interpreter.cpp:3395:16
[task 2023-06-19T22:57:36.651Z] 22:57:36 INFO - PID 21292 | #34 0x7fe963fe86eb in MaybeEnterInterpreterTrampoline /builds/worker/checkouts/gecko/js/src/vm/Interpreter.cpp:400:10
[task 2023-06-19T22:57:36.651Z] 22:57:36 INFO - PID 21292 | #35 0x7fe963fe86eb in js::RunScript(JSContext*, js::RunState&) /builds/worker/checkouts/gecko/js/src/vm/Interpreter.cpp:458:13
[task 2023-06-19T22:57:36.652Z] 22:57:36 INFO - PID 21292 | #36 0x7fe963fe9b2c in js::InternalCallOrConstruct(JSContext*, JS::CallArgs const&, js::MaybeConstruct, js::CallReason) /builds/worker/checkouts/gecko/js/src/vm/Interpreter.cpp:612:13
[task 2023-06-19T22:57:36.652Z] 22:57:36 INFO - PID 21292 | #37 0x7fe965189816 in js::jit::DoCallFallback(JSContext*, js::jit::BaselineFrame*, js::jit::ICFallbackStub*, unsigned int, JS::Value*, JS::MutableHandle<JS::Value>) /builds/worker/checkouts/gecko/js/src/jit/BaselineIC.cpp:1591:10
[task 2023-06-19T22:57:36.652Z] 22:57:36 INFO - PID 21292 | #38 0x1ec868d9de6b (<unknown module>)
Flags: needinfo?(daisuke)
Pushed by dakatsuka.birchill@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/1be4cb72888e
Remove nsNavHistory::BookmarkIdToResultNode() r=mak
|
||
Comment 5•2 years ago
|
||
| bugherder | ||
Status: ASSIGNED → RESOLVED
Closed: 2 years ago
status-firefox116:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → 116 Branch
|
|
Assignee | |
Updated•2 years ago
|
Flags: needinfo?(daisuke)
You need to log in
before you can comment on or make changes to this bug.
Description
•