1816934 - Convert most of services/settings to ES modules

Status: RESOLVED FIXED

(Firefox :: Remote Settings Client, task)

Description

[Mark Banner (:standard8)]

As we're doing elsewhere, we should update the remote settings client code to use ES modules.

However, currently we can't migrate all of it because some of it relies on workers which can't yet import modules (coming soon). There's also a case where a test would need to be rewritten, which I'll file a separate bug for.

Comment 1

[Mark Banner (:standard8)]

Try push: https://treeherder.mozilla.org/jobs?repo=try&revision=c348e188dc60da81540fc025972ac8f14198e340

Comment 2

[Mark Banner (:standard8)]

Attachment: Bug 1816934 - Convert most of services/settings to ES modules. r?leplatrem!

Convert everything apart from items used in workers.

Comment 3

[Mark Banner (:standard8)]

Attachment: Bug 1816934 - Update consumers of services/settings to import ES modules directly. r?leplatrem!

Depends on D169933

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/d6c1d4c0d2a0
Convert most of services/settings to ES modules. r=leplatrem
https://hg.mozilla.org/integration/autoland/rev/7f8a7865868b
Update consumers of services/settings to import ES modules directly. r=leplatrem,extension-reviewers,settings-reviewers,credential-management-reviewers,sgalich,mconley,robwu

Comment 5

[Cristian Tuns]

Backed out for causing dt failures in browser_jsterm_autocomplete_null.js

• Backout link
• Push with failures
• Failure Log
• Failure line: TEST-UNEXPECTED-FAIL | devtools/client/webconsole/test/browser/browser_jsterm_autocomplete_null.js | Got error "ReferenceError: URI is not defined init resource://services-settings/remote-settings.sys.mjs:579 RemoteSettingsInit resource:///modules/BrowserGlue.sys.mjs:2963 _scheduleBestEffortUserIdleTasks resource:///modules/BrowserGlue.sys.mjs:3018 ChromeUtils::IdleDispatch handler*_scheduleBestEffortUserIdleTasks resource:///mo

Comment 6

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/ff399bdca57c
Convert most of services/settings to ES modules. r=leplatrem
https://hg.mozilla.org/integration/autoland/rev/ae6ba90f918a
Update consumers of services/settings to import ES modules directly. r=leplatrem,extension-reviewers,settings-reviewers,credential-management-reviewers,sgalich,mconley,robwu

Comment 7

[Natalia Csoregi [:nataliaCs]]

https://hg.mozilla.org/mozilla-central/rev/ff399bdca57c
https://hg.mozilla.org/mozilla-central/rev/ae6ba90f918a