1816938 - Convert services/settings/Utils.jsm to an ES module

Status: RESOLVED FIXED

(Firefox :: Remote Settings Client, task)

Description

[Mark Banner (:standard8)]

In bug 1816934 we are converting services/settings modules to ES modules.

For that bug I am skipping services/settings/Utils.jsm because migrating that causes test failures in services/settings/test/unit/test_remote_settings_release_prefs.js

The reason for the failures is that the new system does not support unloading ES modules.

I suspect test_remote_settings_release_prefs.js will need splitting up into separate files, so that the tests can be run correctly.

Comment 1

[Anwar Sadat Ayub]

I got this error;

Time elapsed: 807.309seconds
13:54.65 [INFO] Rewritten 18 file(s).
13:54.65 [INFO] Applying eslint --fix for 18 file(s)...
13:54.65 [INFO] 18 files remaining
C:/mozilla-source/mozilla-unified/services/settings/Attachments.sys.mjs
5:10 error 'XPCOMUtils' is defined but never used. no-unused-vars (eslint)

✖ 1 problem (1 error, 0 warnings, 25 fixed)
15:24.18 [INFO] 2 files remaining
✖ 0 problems (0 errors, 0 warnings, 2 fixed)

when I run ./mach esmify --import . --prefix services/settings/Utils.sys.mjs. This comes right after I converted ./mach esmify --convert services/settings/Utils.jsm

Comment 2

[Anwar Sadat Ayub]

Attachment: Bug 1816938 - Convert services/settings/utils.jsm to ES modules. r?Standard8!

Comment 3

[Anwar Sadat Ayub]

Attachment: WIP: Bug 1816938 - Convert services/settings/Utils.jsm to an ES module

Comment 4

[Anwar Sadat Ayub]

Attachment: Bug 1816938 - Convert services/settings/Utils.jsm to an ES module

Comment 5

[Anwar Sadat Ayub]

Attachment: Bug 1816938 - Convert services/settings/utils.jsm to ES modules. r?Standard8

Comment 6

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/93c571dfe5ee
Convert services/settings/utils.jsm to ES modules. r=Standard8,robwu

Comment 7

[Sandor Molnar[:smolnar]]

https://hg.mozilla.org/mozilla-central/rev/93c571dfe5ee