1817099 - Message header no longer shows date/time

Status: RESOLVED FIXED

(Thunderbird :: Message Reader UI, defect, P3)

Description

[Thomas D. (:thomas8)]

Attachment: Screenshot 1: No date/time on message header

112.0a1 (2023-02-15) (64-bit), Win10

STR

• Select a message in thread pane (or open message in a tab)

Actual:

• Message header no longer shows date/time
• In 3-pane, need to move eyes away from message reader context and look for date/time in message list - clumsy, higher mental burden
• In message tab, no way to establish the date/time of the message - ouch

Expected

• Message header should show date/time in-place, which is very important information
• Should not force user to visually scan the message list for the date/time

Alex, should this have a higher priority? Not fatal, but imo pretty relevant, exposed and looking unfinished

Comment 1

[Wayne Mery (:wsmwk)]

workflow impact <> accessibility
"Bugs and enhancement requests related to making Firefox accessible to users with disabilities and special needs."

Comment 2

[Alessandro Castellani [:aleca]]

Assigning this to Elizabeth.
This needs a bit of exploration and digging to figure out why it's not showing up.

Comment 3

[Kai Engert [:KaiE:]]

This is apparently the place that is responsible for showing the date:
https://searchfox.org/comm-central/rev/aa8dc0b45f92a64c4b6b98565155693115909b6c/mail/base/content/msgHdrView.js#1234

Nothing is currently done here, because "x-mozilla-localizeddate" isn't found in currentHeaderData.

That value is created in mailnews/mime/emitters/nsMimeHtmlEmitter.cpp

Using the debugger I confirmed that the code producing the attribute is still reached.
So apparently the attribute is no longer passed along to the JS variable currentHeaderData.

Did the processing of MIME headers change recently (in ash)?

I'll attach a quick hack in order to display at least something.
But that isn't the right fix, because we likely want to continue to show the original localized string that's created by the C++ code?

Comment 4

[Kai Engert [:KaiE:]]

Attachment: 1817099-hack.patch

Comment 5

[Alessandro Castellani [:aleca]]

Thank you so much Kai for the analysis and the WIP patch.
Gentle ping to Geoff to see if he has any hint on what it might be happening.

Comment 6

[Geoff Lankow (:darktrojan)]

Did this happen recently or has it been broken since we merged ash and I just never noticed?

Comment 7

[Alessandro Castellani [:aleca]]

I can use mozregression and figure it out

Comment 8

[Geoff Lankow (:darktrojan)]

Never mind, found it.

Comment 9

[Magnus Melin [:mkmelin]]

It was broken by the ash merge.

Comment 10

[Geoff Lankow (:darktrojan)]

Attachment: Bug 1817099 - Emit X-Mozilla-LocalizedDate to the MailChannel. r=aleca

Also removes the header enumerators, because they aren't doing anything any more.

Comment 11

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/comm-central/rev/06ae41c28984
Emit X-Mozilla-LocalizedDate to the MailChannel. r=aleca

Comment 12

[Wayne Mery (:wsmwk)]

Comment on attachment 9319078 [details]
Bug 1817099 - Emit X-Mozilla-LocalizedDate to the MailChannel. r=aleca

[Triage Comment]
Approved for beta

Comment 13

[Daniel Darnell [:dandarnell]]

Thunderbird 111.0b1:
https://hg.mozilla.org/releases/comm-beta/rev/545e1a37b071