1817153 - Searchbox text color dark theme issue

Status: RESOLVED FIXED

(Thunderbird :: Theme, defect)

Description

[Nicolas Mandil (:NicolasWeb)]

Attachment: TB Search bar text Dark theme issue.jpeg

Steps to reproduce:

1. Open TB (for me macOS 10.13.6, that do not support natively system dark theme)
2. Switch TB to use Dark theme

Actual results:

The text "Search..." kept it black font color

Expected results:

The text should adapt its color

Comment 1

[Richard Marti (:Paenglab)]

Attachment: Bug 1817153 - Inherit the colors for the unified search bar children. r=aleca

Comment 2

[Nicolas Mandil (:NicolasWeb)]

The loop icon should adapt too to Dark theme ;-)
Do I need to make a followup bug ?

Comment 3

[Richard Marti (:Paenglab)]

(In reply to Nicolas Mandil (:NicolasWeb) from comment #2)

The loop icon should adapt too to Dark theme ;-)
Do I need to make a followup bug ?

No, I fixed it in the patch.

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/comm-central/rev/b8cc9a6c7016
Inherit the colors for the unified search bar children. r=aleca

Comment 5

[Richard Marti (:Paenglab)]

Attachment: Bug 1817153 - Follow-up: Fix the unified search bar color on HC and Windows with accent color in titlebar enabled. r=aleca

Comment 6

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/comm-central/rev/b21477410182
Follow-up: Fix the unified search bar color on HC and Windows with accent color in titlebar enabled. r=aleca

Comment 7

[Rob Lemley [:rjl]]

Comment on attachment 9318215 [details]
Bug 1817153 - Inherit the colors for the unified search bar children. r=aleca

[Approval Request Comment]
Regression caused by (bug #): Supernova

For both commits on this bug.

Comment 8

[Wayne Mery (:wsmwk)]

Comment on attachment 9318215 [details]
Bug 1817153 - Inherit the colors for the unified search bar children. r=aleca

[Triage Comment]
Approved for beta

Comment 9

[Wayne Mery (:wsmwk)]

Comment on attachment 9318402 [details]
Bug 1817153 - Follow-up: Fix the unified search bar color on HC and Windows with accent color in titlebar enabled. r=aleca

[Triage Comment]
Approved for beta

Comment 10

[Rob Lemley [:rjl]]

Thunderbird 111.0b1:
https://hg.mozilla.org/releases/comm-beta/rev/ec7759e6815c
https://hg.mozilla.org/releases/comm-beta/rev/02647b4c1641