1817163 - consider to have a way to disable memory track and capturing the information about memory allocations/deallocations

Status: RESOLVED FIXED

(Core :: Gecko Profiler, enhancement, P2)

Description

[Olli Pettay [:smaug][[e-mail]]]

The memory track can be useful, but at least I use it very rarely comparing to the other features in the profiler.
And capturing the information it needs adds quite a bit overhead.
See for example https://share.firefox.dev/3xr8CWE

Comment 1

[Greg Tatum [:gregtatum]]

I agree that it would be nice to be able to turn this off, I was worried it was skewing results when I was analyzing the cost of ICU in Firefox. The primary CPU time was in allocation machinery, and it could have just been profiler overhead.

Comment 4

[Nazım Can Altınova [:canova][:canaltinova on phabricator]]

Attachment: Bug 1817163 - Add a profiler feature for memory tracking to enable the memory hooks r?#profiler

Comment 5

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/dc425d760d09
Add a profiler feature for memory tracking to enable the memory hooks r=profiler-reviewers,perftest-reviewers,android-reviewers,kshampur,aabh,gl

Comment 6

[Norisz Fay [:noriszfay]]

Backed out for causing dt failures on browser_interaction-between-interfaces.js

Backout link

Push with failures

Failure log

The failure log here is also caused by this bug.

Comment 7

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/d642b8b54c96
Add a profiler feature for memory tracking to enable the memory hooks r=profiler-reviewers,perftest-reviewers,android-reviewers,kshampur,aabh,gl

Comment 8

[Sandor Molnar[:smolnar]]

https://hg.mozilla.org/mozilla-central/rev/d642b8b54c96