1892834 - Revisit sp3 profiler settings

Status: RESOLVED FIXED

(Testing :: Raptor, task, P3)

Description

[Kash Shampur [:kshampur] ⌚EST]

We should revisit the sp3 profiling presets
For example we currently get screenshots, and it was brought up that the screenshots itself heavily affect the performance of the test during profiling

Comment 1

[Nazım Can Altınova [:canova][:canaltinova on phabricator]]

Another thing to consider is the "memory" feature we are adding in Bug 1817163.
Before this bug we didn't have a memory feature and memory tracking was always enabled. But Olli and the people from the performance team said that it adds a lot of overhead to sp3 profiling and potentially other tests. Now this is configurable, so it might be a good idea to disable that feature for sp3 and maybe for all performance testing?

Comment 2

[Nazım Can Altınova [:canova][:canaltinova on phabricator]]

Adding the information Olli provided in Matrix to here:
He would like to not have the "screenshots" and "memory" features. I think these ones can be changed globally for raptor browsertime settings here instead of individual handling for sp3 specifically.

He also would like to see TaskController and StyleThread threads, and possibly the IPC (which requires us to add "ipcmessages" to the features list) and "nomarkerstacks" features. I'm not so sure if they should be changed globally for all the browsertime tests or only for sp3. Maybe we can try to add them to sp3 first and see if people like it?

Comment 3

[Kash Shampur [:kshampur] ⌚EST]

Thanks for adding the notes :canova! I agree that we should just add it for sp3 rather than globally

Comment 4

[Markus Stange [:mstange]]

Kash, can you kick off a try push with the suggested settings and then link to a generated profile here? Then we can look at the profile and see if it's good enough or if we need other tweaks.

Comment 5

[Kash Shampur [:kshampur] ⌚EST]

(In reply to Markus Stange [:mstange] from comment #4)

Kash, can you kick off a try push with the suggested settings and then link to a generated profile here? Then we can look at the profile and see if it's good enough or if we need other tweaks.

https://treeherder.mozilla.org/jobs?repo=try&tier=1%2C2%2C3&revision=d625ef03f641d64e58df1de9806b84537c57ca5d

how's this- anything missing?
diff https://hg.mozilla.org/try/rev/864b9eb9453dd93f17e2ad9d196fa30b23934f40 based on comment 2 which replaces the defaults memory& screenshots with ipcmessages & nomarkerstacks

Comment 6

[Markus Stange [:mstange]]

The features look good but the thread filter does not. Can you add the TaskController and StyleThread threads to the list?

Comment 7

[Kash Shampur [:kshampur] ⌚EST]

(In reply to Markus Stange [:mstange] from comment #6)

The features look good but the thread filter does not. Can you add the TaskController and StyleThread threads to the list?

Ah sorry I had misread :canova's comment

https://treeherder.mozilla.org/jobs?repo=try&tier=1%2C2%2C3&revision=ee18b7548bb834c90d7447f847f741bec5e3933f

I see those threads now e.g. random profile

Comment 8

[Olli Pettay [:smaug][[e-mail]]]

That profile looks reasonable to me. We can always tweak later if needed.

Comment 9

[Kash Shampur [:kshampur] ⌚EST]

Attachment: Bug 1892834 - Update speedometer profiler settings. r?#perftest

This patch removes screenshots/memory feature and instead adds
ipcmessages and nomarkerstacks features.

Additionally, the TaskController and StyleThread threads are added

Comment 10

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/c97bc61ae7b5
Update speedometer profiler settings. r=perftest-reviewers,canaltinova,aglavic

Comment 11

[amarc]

https://hg.mozilla.org/mozilla-central/rev/c97bc61ae7b5