1817505 - 10.49 - 5.59% tsvg_static / tscrollx (Linux, OSX) regression on Mon February 13 2023

Status: RESOLVED FIXED

(Core :: Graphics: WebRender, defect)

Description

[Andrej (:aglavic)]

Perfherder has detected a talos performance regression from push 005f973722f7e65152f284acdc8989e4b820cf22. As author of one of the patches included in that push, we need your help to address this regression.

Regressions:

Ratio	Test	Platform	Options	Absolute values (old vs new)
40%	tresize	windows10-64-shippable-qr	e10s fission stylo webrender-sw	6.74 -> 9.45
25%	rasterflood_gradient	linux1804-64-shippable-qr	e10s fission stylo webrender-sw	938.67 -> 702.58
21%	displaylist_mutate	linux1804-64-shippable-qr	e10s fission stylo webrender-sw	3,157.59 -> 3,812.38
20%	displaylist_mutate	linux1804-64-shippable-qr	e10s fission stylo webrender	3,323.69 -> 3,997.76
18%	tresize	linux1804-64-shippable-qr	e10s fission stylo webrender-sw	25.99 -> 30.63
16%	tart	linux1804-64-shippable-qr	e10s fission stylo webrender-sw	3.95 -> 4.60
15%	displaylist_mutate	windows10-64-shippable-qr	e10s fission stylo webrender	2,538.87 -> 2,920.75
15%	displaylist_mutate	macosx1015-64-shippable-qr	e10s fission stylo webrender	1,897.06 -> 2,180.74
15%	tsvgx	linux1804-64-shippable-qr	e10s fission stylo webrender-sw	249.51 -> 286.41
15%	displaylist_mutate	windows10-64-shippable-qr	e10s fission stylo webrender-sw	2,576.34 -> 2,952.67
...	...	...	...	...
7%	tsvgx	windows10-64-shippable-qr	e10s fission stylo webrender-sw	194.03 -> 208.28
6%	tscrollx	macosx1015-64-shippable-qr	e10s fission stylo webrender-sw	0.67 -> 0.71
5%	tp5o_scroll	windows10-64-shippable-qr	e10s fission stylo webrender-sw	1.71 -> 1.80
4%	tart	windows10-64-shippable-qr	e10s fission stylo webrender	3.23 -> 3.34
3%	tsvgx	windows10-64-shippable-qr	e10s fission stylo webrender	164.33 -> 168.68

Improvements:

Ratio	Test	Platform	Options	Absolute values (old vs new)
26%	tp5o responsiveness	linux1804-64-shippable-qr	e10s fission stylo webrender-sw	3.35 -> 2.46
20%	tp5o_webext responsiveness	linux1804-64-shippable-qr	e10s fission stylo webrender-sw	3.97 -> 3.16
3%	rasterflood_gradient	macosx1015-64-shippable-qr	e10s fission stylo webrender-sw	1,290.42 -> 1,324.92

Details of the alert can be found in the alert summary, including links to graphs and comparisons for each of the affected tests. Please follow our guide to handling regression bugs and let us know your plans within 3 business days, or the offending patch(es) may be backed out in accordance with our regression policy.

If you need the profiling jobs you can trigger them yourself from treeherder job view or ask a sheriff to do that for you.

For more information on performance sheriffing please see our FAQ.

Comment 2

[BugBot [:suhaib / :marco/ :calixte]]

Set release status flags based on info from the regressing bug 1811978

Comment 3

[Glenn Watson [:gw]]

I'll investigate this week.

Comment 4

[Glenn Watson [:gw]]

I'm going to back out the regressing patch temporarily, and fix the underlying cause of the regression that this patch exposes.

Comment 5

[Glenn Watson [:gw]]

Attachment: Bug 1817505 - Revert enable of tiled rendering path, for now

This patch exposes an unrelated issue that causes a performance regression.

For now, we'll revert this to get back to a normal baseline. Then, separately
fix the underlying code which regresses perf, then re-land this patch.

Revert "Bug 1811978 - Enable the new tiled rendering path, update test expectations r=gfx-reviewers,nical"

This reverts commit 7f3a2568aabf9fa2358fe0f7421042ba85a23442.

Comment 6

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/2378bf20e662
Revert enable of tiled rendering path, for now r=gfx-reviewers,lsalzman

Comment 7

[Cristina Horotan [:chorotan]]

https://hg.mozilla.org/mozilla-central/rev/2378bf20e662

Comment 8

[Alexandru Ionescu (needinfo me) [:alexandrui]]

(In reply to Pulsebot from comment #6)

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/2378bf20e662
Revert enable of tiled rendering path, for now r=gfx-reviewers,lsalzman

== Change summary for alert #37267 (as of Wed, 22 Feb 2023 04:56:48 GMT) ==

Improvements:

Ratio	Test	Platform	Options	Absolute values (old vs new)	Performance Profiles
14%	stylebench	windows10-64-shippable-qr	fission webrender	46.67 -> 53.04	Before/After
2%	motionmark-htmlsuite	linux1804-64-shippable-qr	fission webrender	58.30 -> 59.62	Before/After

For up to date results, see: https://treeherder.mozilla.org/perfherder/alerts?id=37267

Comment 9

[Andrej (:aglavic)]

(In reply to Pulsebot from comment #6)

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/2378bf20e662
Revert enable of tiled rendering path, for now r=gfx-reviewers,lsalzman

== Change summary for alert #37305 (as of Thu, 23 Feb 2023 21:16:08 GMT) ==

Regressions:

Ratio	Test	Platform	Options	Absolute values (old vs new)
30%	tp5o responsiveness	linux1804-64-shippable-qr	e10s fission stylo webrender-sw	2.52 -> 3.27
22%	tp5o_webext responsiveness	linux1804-64-shippable-qr	e10s fission stylo webrender-sw	3.11 -> 3.80
20%	tp5o_webext responsiveness	linux1804-64-shippable-qr	e10s fission stylo webrender-sw	3.19 -> 3.81
3%	rasterflood_gradient	macosx1015-64-shippable-qr	e10s fission stylo webrender-sw	1,328.96 -> 1,290.00

Improvements:

Ratio	Test	Platform	Options	Absolute values (old vs new)
43%	rasterflood_gradient	linux1804-64-shippable-qr	e10s fission stylo webrender-sw	699.46 -> 1,000.42
25%	tresize	windows10-64-shippable-qr	e10s fission stylo webrender-sw	9.66 -> 7.25
21%	tresize	macosx1015-64-shippable-qr	e10s fission stylo webrender-sw	7.91 -> 6.25
19%	displaylist_mutate	linux1804-64-shippable-qr	e10s fission stylo webrender-sw	3,767.29 -> 3,049.78
18%	tresize	macosx1015-64-shippable-qr	e10s fission stylo webrender-sw	7.98 -> 6.53
...	...	...	...	...
2%	sessionrestore_no_auto_restore	windows10-64-shippable-qr	e10s fission stylo webrender-sw	467.38 -> 457.75

For up to date results, see: https://treeherder.mozilla.org/perfherder/alerts?id=37305