Closed Bug 1811978 Opened 1 year ago Closed 1 year ago

Enable the new tiled rendering path, update test expectations

Categories

(Core :: Graphics: WebRender, task)

task

Tracking

()

RESOLVED FIXED
112 Branch
Tracking Status
firefox112 --- fixed

People

(Reporter: gw, Assigned: gw)

References

Details

Attachments

(1 file)

No description provided.
Assignee: nobody → gwatson
Status: NEW → ASSIGNED
Pushed by gwatson@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/c2571e59e07b
Enable the new tiled rendering path, update test expectations r=gfx-reviewers,nical
Regressions: 1813435

Will investigate them this week and re-land the patches after that.

Flags: needinfo?(gwatson)

Hi Norisz, I've updated the patch with a little extra fuzziness for the failure in https://bugzilla.mozilla.org/show_bug.cgi?id=1813435. However, the existing failures that become more near-permas are unrelated to the content of the patch itself (they may be unrelated race conditions affected by the changes in performance of this patch). I'll do some try runs today with that change to confirm and then re-land.

Pushed by gwatson@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/005f973722f7
Enable the new tiled rendering path, update test expectations r=gfx-reviewers,nical
Status: ASSIGNED → RESOLVED
Closed: 1 year ago
Resolution: --- → FIXED
Target Milestone: --- → 112 Branch
Regressions: 1817113
Regressions: 1817505
No longer regressions: 1817113
Regressions: 1817841

The performance regressions from this patch expose an indirectly related problem. The patch itself is not a problem, but it causes a regression in perf because other parts of the WR code are doing more work than required when this patch is enabled.

I'm going to:

  • Back this patch out, to get us back to the normal performance baseline.
  • Fix / improve the other WR parts that are the underlying cause of this regression.
  • Re-land this patch which will hopefully then not show any perf regressions.
Depends on: 1818115, 1819224, 1818400
Depends on: 1811977
Pushed by gwatson@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/10d16f2e1241
Enable the new tiled rendering path, update test expectations r=gfx-reviewers,nical
Regressions: 1821082
Blocks: 1823579
Regressions: 1827699
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: