1817518 - Context menu items stay highlighted after moving cursor away from them

Status: VERIFIED FIXED

(Firefox :: Menus, defect)

Description

[Gregory Pappas [:gregp]]

Attachment: context_menu.webm

Steps to reproduce:

1. Right click a webpage
2. Hover context menu items with your cursor
3. Move your cursor away from the context menu

Actual results:
Menu item stays highlighted

Expected result:
Menu item is not highlighted

Comment 1

[Emilio Cobos Álvarez (:emilio)]

Yeah before this happened inconsistently. It's not terribly hard to fix but I don't think it's particularly an issue?

Comment 2

[Emilio Cobos Álvarez (:emilio)]

Err didn't intend to close without further discussion. Might be worth checking behavior across platforms and native toolkits.

Comment 3

[Gregory Pappas [:gregp]]

I can reproduce this in my Windows VM as well. It just feels a bit weird because other implementations don't have this behavior. I tested native GTK menus and Windows File Explorer.

Comment 4

[Emilio Cobos Álvarez (:emilio)]

Attachment: Bug 1817518 - De-select closed menuitems on mouseout. r=mstange

I knew this sounded familiar, see bug 1811466.

The patch is a one-liner, the rest is a test. I'd ask smaug for review
but he's on PTO so... Markus, maybe you can take a look?

Comment 5

[BugBot [:suhaib / :marco/ :calixte]]

Set release status flags based on info from the regressing bug 1805414

Comment 6

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/87139fa929ac
De-select closed menuitems on mouseout. r=mstange

Comment 7

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/8f604548e718
Try to activate menuitem harder.

Comment 8

[Iulian Moraru]

https://hg.mozilla.org/mozilla-central/rev/87139fa929ac
https://hg.mozilla.org/mozilla-central/rev/8f604548e718

Comment 9

[Ryan VanderMeulen [:RyanVM]]

Did you want to nominate this for Beta uplift?

Comment 10

[Emilio Cobos Álvarez (:emilio)]

Comment on attachment 9318528 [details]
Bug 1817518 - De-select closed menuitems on mouseout. r=mstange

Beta/Release Uplift Approval Request

• User impact if declined: comment 0
• Is this code covered by automated tests?: Yes
• Has the fix been verified in Nightly?: Yes
• Needs manual test from QE?: Yes
• If yes, steps to reproduce: comment 0
• List of other uplifts needed: none
• Risk to taking this patch: Low
• Why is the change risky/not risky? (and alternatives if risky): Simple one-liner + test.
• String changes made/needed: none
• Is Android affected?: No

Comment 11

[Donal Meehan [:dmeehan]]

Comment on attachment 9318528 [details]
Bug 1817518 - De-select closed menuitems on mouseout. r=mstange

Approved for 111.0b8

Comment 12

[Donal Meehan [:dmeehan]]

https://hg.mozilla.org/releases/mozilla-beta/rev/a97ef3be2b97
https://hg.mozilla.org/releases/mozilla-beta/rev/d89b13e01681

Comment 13

[Catalin Sasca, Desktop QA [:csasca]]

Reproduced the issue on Firefox 112.0a1 (2023-02-17) on Ubuntu 22.04 by following the STR from Comment 0.

The issue is fixed on Firefox 111.0b8 (treeherder build) and Firefox 112.0a1 (2023-03-02) on the same system.