1817659 - Network limiter doesn't work

Status: RESOLVED FIXED

(DevTools :: Netmonitor, defect, P1)

Description

[Lenni]

User Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:109.0) Gecko/20100101 Firefox/110.0

Steps to reproduce:

1. Open dev tools
2. Go to network tab
3. Select any throttling option that is not "no throttling"
4. Try to load any web page

Actual results:

The browser acts as if it is completely offline, even when fast speeds are selected (Wi-Fi)

Expected results:

Just slow down the connection, not completely freeze it.

Comment 1

[BugBot [:suhaib / :marco/ :calixte]]

The Bugbug bot thinks this bug should belong to the 'Core::Networking' component, and is moving the bug to that component. Please correct in case you think the bot is wrong.

Comment 2

[Valentin Gosu [:valentin] (he/him)]

mozregression points to:
https://hg.mozilla.org/integration/autoland/pushloghtml?fromchange=2b67bd0dd255a576b4b2dbc7ab1c2614e096ce2d&tochange=abe601ec2aa53511534e43a2c3509a577a050ce4

Comment 3

[Valentin Gosu [:valentin] (he/him)]

console output:

JavaScript error: resource://devtools/shared/network-observer/NetworkObserver.sys.mjs, line 1123: NS_ERROR_NOT_AVAILABLE: Component returned failure code: 0x80040111 (NS_ERROR_NOT_AVAILABLE) [nsICacheInfoChannel.isFromCache]
Handler function threw an exception: [Exception... "Component returned failure code: 0x80040111 (NS_ERROR_NOT_AVAILABLE) [nsICacheInfoChannel.isFromCache]"  nsresult: "0x80040111 (NS_ERROR_NOT_AVAILABLE)"  location: "JS frame :: resource://devtools/shared/network-observer/NetworkObserver.sys.mjs :: #isFromCache :: line 1123"  data: no]
Stack: #isFromCache@resource://devtools/shared/network-observer/NetworkObserver.sys.mjs:1123:22
#onResponseHeader@resource://devtools/shared/network-observer/NetworkObserver.sys.mjs:1021:43
#dispatchActivity@resource://devtools/shared/network-observer/NetworkObserver.sys.mjs:537:31
#maybeEmit@resource://devtools/shared/network-observer/NetworkThrottleManager.sys.mjs:259:15
#maybeEmitEvents@resource://devtools/shared/network-observer/NetworkThrottleManager.sys.mjs:228:22
addActivityCallback@resource://devtools/shared/network-observer/NetworkThrottleManager.sys.mjs:203:26
@resource://devtools/shared/network-observer/NetworkObserver.sys.mjs:635:37
makeInfallible/<@resource://devtools/shared/DevToolsInfaillibleUtils.sys.mjs:43:22
Line: 1123, column: 0
console.error: ({})
Handler function threw an exception: [Exception... "Component returned failure code: 0x80040111 (NS_ERROR_NOT_AVAILABLE) [nsICacheInfoChannel.isFromCache]"  nsresult: "0x80040111 (NS_ERROR_NOT_AVAILABLE)"  location: "JS frame :: resource://devtools/shared/network-observer/NetworkObserver.sys.mjs :: #isFromCache :: line 1123"  data: no]
Stack: #isFromCache@resource://devtools/shared/network-observer/NetworkObserver.sys.mjs:1123:22
#onResponseHeader@resource://devtools/shared/network-observer/NetworkObserver.sys.mjs:1021:43
#dispatchActivity@resource://devtools/shared/network-observer/NetworkObserver.sys.mjs:537:31
#maybeEmit@resource://devtools/shared/network-observer/NetworkThrottleManager.sys.mjs:259:15
#maybeEmitEvents@resource://devtools/shared/network-observer/NetworkThrottleManager.sys.mjs:228:22
addActivityCallback@resource://devtools/shared/network-observer/NetworkThrottleManager.sys.mjs:203:26
@resource://devtools/shared/network-observer/NetworkObserver.sys.mjs:635:37
makeInfallible/<@resource://devtools/shared/DevToolsInfaillibleUtils.sys.mjs:43:22
Line: 1123, column: 0
console.error: ({})
JavaScript error: resource://devtools/shared/network-observer/NetworkObserver.sys.mjs, line 1123: NS_ERROR_NOT_AVAILABLE: Component returned failure code: 0x80040111 (NS_ERROR_NOT_AVAILABLE) [nsICacheInfoChannel.isFromCache]
JavaScript error: resource://devtools/shared/network-observer/NetworkObserver.sys.mjs, line 1123: NS_ERROR_NOT_AVAILABLE: Component returned failure code: 0x80040111 (NS_ERROR_NOT_AVAILABLE) [nsICacheInfoChannel.isFromCache]
JavaScript error: resource://devtools/shared/network-observer/NetworkObserver.sys.mjs, line 1123: NS_ERROR_NOT_AVAILABLE: Component returned failure code: 0x80040111 (NS_ERROR_NOT_AVAILABLE) [nsICacheInfoChannel.isFromCache]
JavaScript error: resource://devtools/shared/network-observer/NetworkObserver.sys.mjs, line 1123: NS_ERROR_NOT_AVAILABLE: Component returned failure code: 0x80040111 (NS_ERROR_NOT_AVAILABLE) [nsICacheInfoChannel.isFromCache]
JavaScript error: resource://devtools/shared/network-observer/NetworkObserver.sys.mjs, line 1123: NS_ERROR_NOT_AVAILABLE: Component returned failure code: 0x80040111 (NS_ERROR_NOT_AVAILABLE) [nsICacheInfoChannel.isFromCache]
[Child 16554, Main Thread] WARNING: NS_ENSURE_SUCCESS(rv, rv) failed with result 0x80004005 (NS_ERROR_FAILURE): file mozilla-central/toolkit/xre/nsXREDirProvider.cpp:478
[Child 16554, Main Thread] WARNING: NS_ENSURE_SUCCESS(rv, rv) failed with result 0x80004005 (NS_ERROR_FAILURE): file mozilla-central/toolkit/xre/nsXREDirProvider.cpp:478
[Child 16554, Main Thread] WARNING: NS_ENSURE_SUCCESS(rv, rv) failed with result 0x80004005 (NS_ERROR_FAILURE): file mozilla-central/toolkit/xre/nsXREDirProvider.cpp:478
[Child 16554, Main Thread] WARNING: NS_ENSURE_SUCCESS(rv, rv) failed with result 0x80004005 (NS_ERROR_FAILURE): file mozilla-central/toolkit/xre/nsXREDirProvider.cpp:478
JavaScript error: resource://devtools/shared/network-observer/NetworkObserver.sys.mjs, line 1123: NS_ERROR_NOT_AVAILABLE: Component returned failure code: 0x80040111 (NS_ERROR_NOT_AVAILABLE) [nsICacheInfoChannel.isFromCache]
JavaScript error: resource://devtools/shared/network-observer/NetworkResponseListener.sys.mjs, line 573: NS_ERROR_INVALID_CONTENT_ENCODING: Component returned failure code: 0x804b001b (NS_ERROR_INVALID_CONTENT_ENCODING) [nsIStreamListener.onDataAvailable]
JavaScript error: resource://devtools/shared/network-observer/NetworkObserver.sys.mjs, line 1123: NS_ERROR_NOT_AVAILABLE: Component returned failure code: 0x80040111 (NS_ERROR_NOT_AVAILABLE) [nsICacheInfoChannel.isFromCache]
[Parent 16179, Cache2 I/O] WARNING: 'NS_FAILED(aResult)', file mozilla-central/netwerk/cache2/CacheFile.cpp:661
[Child 16352, Main Thread] WARNING: IPC message 'PSessionStore::Msg_SessionStoreUpdate' discarded: actor cannot send: file mozilla-central/ipc/glue/ProtocolUtils.cpp:504

Comment 4

[BugBot [:suhaib / :marco/ :calixte]]

Set release status flags based on info from the regressing bug 1790370

Comment 5

[Julian Descottes [:jdescottes]]

Based on https://searchfox.org/mozilla-central/rev/0e3779abe6ad44feb787a295fbb67bc9fe4e927a/netwerk/base/nsICacheInfoChannel.idl#45-50 I was only expecting isFromCache to return undefined or a boolean. Is it expected that the method throws in some cases?

Comment 6

[Julian Descottes [:jdescottes]]

Looks like this only happens when we set some latency in our throttling configuration (which is the case for all our profiles), but it seems we don't cover this in tests.

Comment 7

[Valentin Gosu [:valentin] (he/him)]

Yes, it seems to throw if not called before OnStopRequest. But I'm not sure that's still a proper thing to do.
I filed a bug to change that.

Comment 8

[Julian Descottes [:jdescottes]]

Thanks! I'll still fix the devtools logic and add proper tests

Comment 9

[Julian Descottes [:jdescottes]]

Attachment: Bug 1817659 - [devtools] Catch isFromCache exception in network observer

Comment 10

[Julian Descottes [:jdescottes]]

Attachment: Bug 1817659 - [devtools] Sort netmonitor test manifest alphabetically

Depends on D170346

Comment 11

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/65e50dd3aa71
[devtools] Catch isFromCache exception in network observer r=bomsy
https://hg.mozilla.org/integration/autoland/rev/c2a70384e2be
[devtools] Sort netmonitor test manifest alphabetically r=bomsy

Comment 12

[Norisz Fay [:noriszfay]]

https://hg.mozilla.org/mozilla-central/rev/65e50dd3aa71
https://hg.mozilla.org/mozilla-central/rev/c2a70384e2be

Comment 13

[Julian Descottes [:jdescottes]]

Comment on attachment 9318728 [details]
Bug 1817659 - [devtools] Catch isFromCache exception in network observer

Beta/Release Uplift Approval Request

• User impact if declined: Using the network throttling feature in the DevTools network monitor or in RDM prevents requests from completing.
• Is this code covered by automated tests?: Yes
• Has the fix been verified in Nightly?: No
• Needs manual test from QE?: No
• If yes, steps to reproduce:
• List of other uplifts needed: None
• Risk to taking this patch: Low
• Why is the change risky/not risky? (and alternatives if risky): On the implementation side, we are only adding a try catch around a platform call which can sometimes throw.
  We also added missing automated tests to check that our network profiles were working correctly.
• String changes made/needed:
• Is Android affected?: No

Comment 14

[Donal Meehan [:dmeehan]]

Comment on attachment 9318728 [details]
Bug 1817659 - [devtools] Catch isFromCache exception in network observer

Approved for 111.0b6

Comment 15

[Donal Meehan [:dmeehan]]

Comment on attachment 9318748 [details]
Bug 1817659 - [devtools] Sort netmonitor test manifest alphabetically

Approved for 111.0b6

Comment 16

[Donal Meehan [:dmeehan]]

https://hg.mozilla.org/releases/mozilla-beta/rev/3eb3c195a9d8
https://hg.mozilla.org/releases/mozilla-beta/rev/8a32bce8689b