1817669 - Sidebar switcher popup misaligned with the switcher button

Status: VERIFIED FIXED

(Toolkit :: UI Widgets, defect)

Description

[Itiel]

Attachment: Screenshot

STR (on Windows, at least):

1. Open the sidebar
2. Click the switcher button
3. Observe the popup alignment with the switcher

This is a 2-step regression: in bug 1788273 is was regressed so that the popup is misaligned only horizontally, and after bug 1789278 the popoup is misaligned both horizontally and vertically, in a way that its top side starts "inside" the button. See attached.

Comment 1

[Emilio Cobos Álvarez (:emilio)]

The panel is intentionally aligned to the icon here, so behavior seems intentional. But we could replace this._icon by this._switcherTarget to get the "aligned to button" behavior.

Comment 2

[Itiel]

(In reply to Emilio Cobos Álvarez (:emilio) from comment #1)

The panel is intentionally aligned to the icon here, so behavior seems intentional. But we could replace this._icon by this._switcherTarget to get the "aligned to button" behavior.

Looking at https://bugzilla.mozilla.org/show_bug.cgi?id=1355324#c9, I think the intention was to align the arrow to the icon. But now that we're not using arrows anymore there's no need in diverging from the usual standard.

Comment 3

[Emilio Cobos Álvarez (:emilio)]

Attachment: Bug 1817669 - Tweak sidebar popup alignment. r=Itiel,aminomancer,dao

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/1fe1f235ba1a
Tweak sidebar popup alignment. r=aminomancer

Comment 5

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/55f6654e50f6
Remove now-dead declaration.

Comment 6

[Serban Stanca [:SerbanS]]

https://hg.mozilla.org/mozilla-central/rev/1fe1f235ba1a
https://hg.mozilla.org/mozilla-central/rev/55f6654e50f6

Comment 7

[BugBot [:suhaib / :marco/ :calixte]]

The patch landed in nightly and beta is affected.
:emilio, is this bug important enough to require an uplift?

• If yes, please nominate the patch for beta approval.
• If no, please set status-firefox111 to wontfix.

For more information, please visit auto_nag documentation.

Comment 8

[Emilio Cobos Álvarez (:emilio)]

Comment on attachment 9318630 [details]
Bug 1817669 - Tweak sidebar popup alignment. r=Itiel,aminomancer,dao

Beta/Release Uplift Approval Request

• User impact if declined: comment 0
• Is this code covered by automated tests?: No
• Has the fix been verified in Nightly?: Yes
• Needs manual test from QE?: Yes
• If yes, steps to reproduce: comment 0
• List of other uplifts needed: none
• Risk to taking this patch: Low
• Why is the change risky/not risky? (and alternatives if risky): Very targeted fix, though also we've shipped this already so not sure if worth uplifting.
• String changes made/needed: none
• Is Android affected?: No

Comment 9

[Donal Meehan [:dmeehan]]

Comment on attachment 9318630 [details]
Bug 1817669 - Tweak sidebar popup alignment. r=Itiel,aminomancer,dao

Approved for 111.0b5

Comment 10

[Donal Meehan [:dmeehan]]

https://hg.mozilla.org/releases/mozilla-beta/rev/5174a3d64538
https://hg.mozilla.org/releases/mozilla-beta/rev/b06a9891b75c

Comment 11

[Catalin Sasca, Desktop QA [:csasca]]

Reproduced the misalignment on Firefox 112.0a1 (2023-02-19) on macOS 13.2.1 by following the STR from Comment 0.

The sidebar popup is aligned as expected on Firefox 112.0a1 (2023-02-22) and Firefox 111.0b5 (treeherder build). Tests were performed on macOS 13.2.1, Windows 11 and Ubuntu 22.04.