1817709 - Block video overlay with non-intel GPUs on Windows 10

Status: RESOLVED FIXED

(Core :: Graphics, task)

Description

[Sotaro Ikeda [:sotaro]]

Video overlay does not work well with non-intel GPUs on Windows 10. See Bug 1817269, Bug 1817617.

Comment 1

[Sotaro Ikeda [:sotaro]]

From gfx-firefox channel

uncannyvalley (ahale)
My current sense is that blocking non-intel video overlay on Windows 10 may be the easiest stopgap
jrmuizel
yeah, we'll basically have that after the new blocklist rule goes out

Comment 2

[Sotaro Ikeda [:sotaro]]

Attachment: Bug 1817709 - Block video overlay with non-intel GPUs on Windows 10

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/3408467a0885
Block video overlay with non-intel GPUs on Windows 10 r=jrmuizel,gfx-reviewers

Comment 4

[Jeff Muizelaar [:jrmuizel]]

It seems like there were a number of reporters that also had trouble on Win11: https://www.reddit.com/r/firefox/comments/115mdtn/hardware_acceleration_results_in_stuttering_video/

Comment 5

[Cristina Horotan [:chorotan]]

https://hg.mozilla.org/mozilla-central/rev/3408467a0885

Comment 6

[Sotaro Ikeda [:sotaro]]

(In reply to Jeff Muizelaar [:jrmuizel] from comment #4)

It seems like there were a number of reporters that also had trouble on Win11: https://www.reddit.com/r/firefox/comments/115mdtn/hardware_acceleration_results_in_stuttering_video/

Hmm, I am going to look into it.

Comment 7

[Alice0775 White]

After running latest Nightly which includes this patch, I don't see any information about 'VIDEO_OVERLAY' in about:support.

Is this intentional?

Comment 8

[Sotaro Ikeda [:sotaro]]

It is not intentional. And I am going to backout the patch, since the problem happens also on Win11.

Comment 9

[Sotaro Ikeda [:sotaro]]

(In reply to Jeff Muizelaar [:jrmuizel] from comment #4)

It seems like there were a number of reporters that also had trouble on Win11: https://www.reddit.com/r/firefox/comments/115mdtn/hardware_acceleration_results_in_stuttering_video/

D170311 is going to be backed out by Bug 1818637.

I re-checked similar bugs and from the following. Then I wonder if there might be a case that "Pending frames" became longer during video playback with video overlay. And the long pending frames might cause the problem.

• https://bugzilla.mozilla.org/show_bug.cgi?id=1792015#c27
• https://searchfox.org/mozilla-central/rev/3ede9deb876ad5d6389cb51b371d4a4c8d788deb/gfx/webrender_bindings/RenderCompositorANGLE.cpp#797

DCLayerTree uses a lot of tiles that are merged by DWM. Then the long pending frames might happen depending on the situations with NVIDIA GPUs or with AMD GPUs.