1817269 - Twitch.tv issue after 110 update

Status: RESOLVED FIXED

(Core :: Graphics, defect, P1)

Description

[Attila Suranyi]

Attachment: Firefox and computer information

User Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:109.0) Gecko/20100101 Firefox/110.0

Steps to reproduce:

Update to Firefox 110
Open any stream on https://www.twitch.tv

Actual results:

Low video frame rate
Lots of dropped frames
The bottom and top edges of the video flicker

Expected results:

Fluid video playback, no flicker

(If I disable hardware acceleration the problem disappears.
YouTube works fine with hardware acceleration)

Comment 1

[BugBot [:suhaib / :marco/ :calixte]]

The Bugbug bot thinks this bug should belong to the 'Core::Audio/Video: Playback' component, and is moving the bug to that component. Please correct in case you think the bot is wrong.

Comment 2

[Alastor Wu [:alwu]]

We didn't land anything which might affect hardware decoding in Fx110. Sotaro, do you think if this might be related with bug 1798245, or any gfx side change which you can think of might affect hardware decoding? Thanks.

Comment 3

[Attila Suranyi]

Additional info: Twitch flickering only occurs when the mouse pointer is over the video.

I found some problematic YouTube videos too (dropped frames, flickering progress bar)
Examples:
https://www.youtube.com/watch?v=tox5Dn0k9-E
https://www.youtube.com/watch?v=gJk5QssH0KE

Comment 4

[Sotaro Ikeda [:sotaro]]

Hi Attila Suranyi , can you check if the following address the problem for you?
-[1] Set pref "gfx.webrender.dcomp-video-yuv-overlay-win" to true in about:config
-[2] Restart Firefox

From about:support RGB overlay type is software.

• OverlaySupport: NV12=Scaling YUV2=None BGRA8=Software RGB10A2=None

I wonder if Software overlay does not work on AMD GPU.

• https://source.chromium.org/chromium/chromium/src/+/main:gpu/config/gpu_driver_bug_list.json;l=3542

And the problem seems to be triggered by video overlay usage.
The problem seemed to be addressed by setting pref "gfx.webrender.dcomp-video-overlay-win" to false in about:config.

Comment 6

[Vakanata]

https://bugzilla.mozilla.org/show_bug.cgi?id=1817338
I have the same problem only with all videos online. Disabling hardware acceleration solves the problem, but then Mozilla loads the processor by 70% when playing video (I have an old I3 7100)
The specified parameter did not give any effect.
I generally unloaded AMD Software - no reaction. That is, literally in the morning everything everywhere worked with hardware inclusion, as it was updated to version 110.0, this game began.
I wrote about this error first on Community.Mozilla and there a person resigned with an Nvidia 3050 video card

Comment 7

[Vakanata]

everything worked before the update(In reply to Vakanata from comment #6)

https://bugzilla.mozilla.org/show_bug.cgi?id=1817338
I have the same problem only with all videos online. Disabling hardware acceleration solves the problem, but then Mozilla loads the processor by 70% when playing video (I have an old I3 7100)
The specified parameter did not give any effect.
I generally unloaded AMD Software - no reaction. That is, literally in the morning everything everywhere worked with hardware inclusion, as it was updated to version 110.0, this game began.
I wrote about this error first on Community.Mozilla and there a person resigned with an Nvidia 3050 video card

still in the morning, before this update everything worked fine with hardware acceleration

Comment 8

[Sotaro Ikeda [:sotaro]]

Attachment: Bug 1817269 - Backout Bug 1798245

Comment 9

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/d4b472c6ec50
Backout Bug 1798245 r=jrmuizel,gfx-reviewers

Comment 10

[Sotaro Ikeda [:sotaro]]

Comment on attachment 9318317 [details]
Bug 1817269 - Backout Bug 1798245

Beta/Release Uplift Approval Request

• User impact if declined: Bug 1817269 could happens with AMD GPUs.
• Is this code covered by automated tests?: Yes
• Has the fix been verified in Nightly?: No
• Needs manual test from QE?: No
• If yes, steps to reproduce:
• List of other uplifts needed: none
• Risk to taking this patch: Low
• Why is the change risky/not risky? (and alternatives if risky): the change is not risky. The patch just backout Bug 1798245.
• String changes made/needed: none
• Is Android affected?: No

Comment 11

[Jeff Muizelaar [:jrmuizel]]

Ashley has a similar GPU to Attila and is going to try to reproduce locally

Comment 12

[Ashley Hale [:ahale]]

Attachment: about:support from Firefox 110.0 on Windows 10 22H2 with Radeon RX 6900 XT - unsuccessful repro attempt

I've been trying to reproduce this on a similar setup (Radeon RX 6900 XT, Windows 10 22H2, single 2560x1600@60hz monitor on Displayport) but haven't been able to get it to break so far, I attached my about:support to contrast with the others.

Comment 13

[Ashley Hale [:ahale]]

Attachment: text version of about:support from Firefox 110.0 on Windows 10 22H2 with Radeon RX 6900 XT - unsuccessful repro attempt

Comment 14

[Ashley Hale [:ahale]]

Differences I notice in about:support on the original poster's system ('op') and my system that can't repro the problem ('me'):
op: OS: Windows_NT 10.0 17763
me: OS: Windows_NT 10.0 19045
op: WebGL 1 Driver Renderer: Google Inc. (AMD) -- ANGLE (AMD, AMD Radeon RX 6700 XT Direct3D11 vs_5_0 ps_5_0, D3D11-31.0.12044.3)
me: WebGL 1 Driver Renderer: Google Inc. (AMD) -- ANGLE (AMD, AMD Radeon RX 6900 XT Direct3D11 vs_5_0 ps_5_0, D3D11-31.0.12027.7000)

So I have a slightly older GPU driver but a newer Windows 10 version, may be a factor but I am not sure.

Comment 15

[Ryan VanderMeulen [:RyanVM]]

Vakanata, can you please share your about:support info as well?

Comment 16

[Vakanata]

Attachment: Vakanata about:support text file 110.0 Firefox

Comment 17

[Sotaro Ikeda [:sotaro]]

(In reply to Ashley Hale [:ahale] from comment #14)

op: OS: Windows_NT 10.0 17763
me: OS: Windows_NT 10.0 19045

Attila Suranyi , window version seemed old, can you update Windows10 version and can you check if the problem happens after the update?

Comment 18

[Vakanata]

I tried to make a clean profile, the problem persisted there
Everything Works in safe mode everywhere without glitches with hardware acceleration.
I also wanted to record as the author of the topic a video with cursor and video brakes, and when recording was turned on, glitches and brakes disappeared, and when turned off they returned without restarting the browser (fiction in Bandicam and AMD Software) In Windows Xbox Live, when recording, glitches did not disappear, but on recording the video is smooth without jerks

Comment 19

[Cristina Horotan [:chorotan]]

https://hg.mozilla.org/mozilla-central/rev/d4b472c6ec50

Comment 20

[Donal Meehan [:dmeehan]]

Comment on attachment 9318317 [details]
Bug 1817269 - Backout Bug 1798245

Approved for 111.0b3

Comment 21

[Donal Meehan [:dmeehan]]

https://hg.mozilla.org/releases/mozilla-beta/rev/04a0d5b48a05

Comment 22

[Bogdan Maris, Desktop Test Engineering]

SV QA does not have any hardware similar with the ones from this bug, we only have two machines with AMD Graphics cards (AMD Rx550 and Radeon HD5450) which are very old. Though we tried to reproduce the issue from comment 0 but without success. We will also not be able to verify this fix on latest builds due to the above so our best bet will be the reporter and the other people who reproduced this in the first place.

Comment 23

[Attila Suranyi]

(In reply to Sotaro Ikeda [:sotaro] from comment #4)

Hi Attila Suranyi , can you check if the following address the problem for you?
-[1] Set pref "gfx.webrender.dcomp-video-yuv-overlay-win" to true in about:config
-[2] Restart Firefox

I changed the setting "gfx.webrender.dcomp-video-yuv-overlay-win" to true, but there was no visible change.

I am using Windows 10 LTSC 2019, I will see if it is possible to upgrade to LTSC 2021.
I am using AMD Pro Edition 22.Q4 driver for the video card.

(Sorry for the late reply, I was at work.)

Comment 24

[Attila Suranyi]

Upgrade to Win 10 LTSC 2021 (21H2) solved the problems for me

Comment 26

[Ashley Hale [:ahale]]

Attachment: about:support on windows 10 1903 18362 not reproducing issue

Comment 27

[Sotaro Ikeda [:sotaro]]

(In reply to Attila Suranyi from comment #24)

Upgrade to Win 10 LTSC 2021 (21H2) solved the problems for me

Great! Thank you for the confirmation!

Comment 28

[Ashley Hale [:ahale]]

Attachment: about:support on windows 10 1903 18362 with driver 31.0.12029.10015 successful repro of issue

I was able to reproduce the issue with driver version 31.0.12029.10015 ( https://www.amd.com/en/support/kb/release-notes/rn-rad-win-22-11-2 ).

Comment 29

[Ashley Hale [:ahale]]

Attachment: about:support on windows 10 1903 18362 with driver 31.0.14001.45012 works fine

Updating to newer AMD driver 31.0.14001.45012 ( https://www.amd.com/en/support/kb/release-notes/rn-rad-win-23-2-1 ) fixed the problem as far as I can tell.

Comment 30

[Ashley Hale [:ahale]]

Version pairs (Windows, AMD driver) we know work or don't work:

• Comment #0 - Windows_NT 10.0 17763 - 31.0.12044.3 - BAD
• Comment #13 - Windows_NT 10.0 19045 - 31.0.12027.7000 - OK
• Comment #16 - Windows_NT 6.1 7600 - 31.0.12029.10015 - BAD
• Comment #26 - Windows_NT 10.0 18362 - 27.20.14501.28009 - OK
• Comment #28 - Windows_NT 10.0 18362 - 31.0.12029.10015 - BAD
• Comment #29 - Windows_NT 10.0 18362 - 31.0.14001.45012 - OK

Hypothesis - driver version has some broken range:

• 27.20.14501.28009 - OK
• 31.0.12027.7000 - OK
• 31.0.12029.10015 - BAD
• 31.0.12044.3 - BAD
• 31.0.14001.45012 - OK

Comment 31

[Jeff Muizelaar [:jrmuizel]]

Downloadable blocklist rule is live.

Comment 32

[Ashley Hale [:ahale]]

Attachment: about:support on windows 10 1903 18362 with driver 31.0.12029.10015 with blocklist deployed

Blocklist was not picked up on first run of Firefox today (and this led to a TDR which AMD bug reporter asked for a report about), but after restarting Firefox the blocklist is active and video works fine.

Comment 33

[Ashley Hale [:ahale]]

Attachment: about:support after updating driver and restarting browser once - blocklisted on first run

Comment 34

[Ashley Hale [:ahale]]

Attachment: about:support with updated driver after manually clearing video overlay failure prefs

It seems the blocklist does not clear itself after driver update, so I've manually cleared the prefs, attached about:support.

It seems bad if this blocklist sticks around after driver update?

Comment 35

[Sotaro Ikeda [:sotaro]]

:ahale, can you take Firefox Profiler with "Graphics" settings and "Media" settings when the problem happens?

Comment 36

[Pascal Chevrel:pascalc]

Comment on attachment 9318317 [details]
Bug 1817269 - Backout Bug 1798245

110 regression, uplift approved for 110.0.1, thanks.

Comment 37

[Pascal Chevrel:pascalc]

https://hg.mozilla.org/releases/mozilla-release/rev/e058ec24bcd1