1817796 - Message reader renders plain text gentle smile :) emoticon as strong "smile"/laugh 😄 emoji, which is an inappropriate distortion of tone

Status: RESOLVED FIXED

(Thunderbird :: General, defect)

Description

[Pierre Ossman]

Steps to reproduce:

Got an email with the ":)" emoticon.

Actual results:

Thunderbird replaces ":)" with the emoji 😄.

Expected results:

Thunderbird should have replaced ":)" with a more similar emoji, e.g. 🙂. The current replacement gives a very different tone which can be very inappropriate.

Comment 1

[Thomas D. (:thomas8)]

That's true Pierre.
One day, we'll just give you the full choice of emojis (bug 1727498).
Until then, the current choice isn't great at all and obviously with such a limited number, text-emoji relation can easily go wrong. If we fix this without increasing the number of available emojis, we'll lose 😄 from the set, which is perhaps better than inappropriate rendering.

STR

• Compose msg having :)
• Enforce plaintext via Options > Sending Format > Only plaintext (for some reason, I didn't get plaintext otherwise, even though there was no formatting)?
• Ctrl+Shift+Enter to send later to outbox
• Check ("received") msg in outbox for appearance of smiley

Actual result

• Thunderbird replaces the gentle plain text smile :) with the emoji 😄, which is an extremely joyful/laughing face. This replacement gives a very different tone which can be very inappropriate.

Expected

• Thunderbird should have replaced plain text :) with a more similar/toned-down emoji, e.g. 🙂, to represent a gentle smile.

Comment 2

[Thomas D. (:thomas8)]

See bug 1801679 where a similar problem has been fixed.
I guess we would accept a patch.
😄 is really inappropriate for a gentle smile, also from the Insert a smiley face menu.

Comment 3

[Thomas D. (:thomas8)]

Although the official description does say "SMILING FACE WITH OPEN MOUTH AND SMILING EYES" for 😄, but yeah, there are other smiling faces with a less extreme "smile".

http://xahlee.info/comp/unicode_index.html?q=%F0%9F%98%84
https://www.unicode.org/charts/PDF/U1F600.pdf

Comment 5

[Magnus Melin [:mkmelin]]

Attachment: Bug 1817796 - Adjust smiley and embarassed smiley-to-emoji conversion. r=valentin

Adjust the smiley icon.
Also adjust embarassed detection which was wrong. The :-[ is more like bummed I think, but it's also "bat" so given it's not always clear what it means, probably best to not convert that.
Embarrassed emoji according to https://en.wikipedia.org/wiki/List_of_emoticons

Comment 6

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/b3a4513f58db
Adjust smiley and embarassed smiley-to-emoji conversion. r=necko-reviewers,valentin

Comment 7

[Cosmin Sabou [:CosminS]]

https://hg.mozilla.org/mozilla-central/rev/b3a4513f58db

Comment 8

[Richard Marti (:Paenglab)]

Attachment: Bug 1817796 - Use the gentle smile smiley instead of the open mouth smiley in composer and calendar. r=#thunderbird-reviewers

Comment 9

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/comm-central/rev/246047602c9b
Use the gentle smile smiley instead of the open mouth smiley in composer and calendar. r=mkmelin

Comment 10

[Magnus Melin [:mkmelin]]

Comment on attachment 9337436 [details]
Bug 1817796 - Adjust smiley and embarassed smiley-to-emoji conversion. r=valentin

Beta/Release Uplift Approval Request

• User impact if declined: Some smileys converted to slightly wrong emojis
• Is this code covered by automated tests?: Yes
• Has the fix been verified in Nightly?: Yes
• Needs manual test from QE?: No
• If yes, steps to reproduce: The code is AFAIK really only used in Thunderbird.
  To repro, send an email with :) and notice how the emoji it converts to looks
• List of other uplifts needed: None
• Risk to taking this patch: Low
• Why is the change risky/not risky? (and alternatives if risky): Visual small change
• String changes made/needed: none
• Is Android affected?: No

Comment 11

[Donal Meehan [:dmeehan]]

Comment on attachment 9337436 [details]
Bug 1817796 - Adjust smiley and embarassed smiley-to-emoji conversion. r=valentin

Approved for 115.0b4.

Comment 12

[Donal Meehan [:dmeehan]]

https://hg.mozilla.org/releases/mozilla-beta/rev/ab11ecaabf3e

Comment 13

[Wayne Mery (:wsmwk)]

Comment on attachment 9338230 [details]
Bug 1817796 - Use the gentle smile smiley instead of the open mouth smiley in composer and calendar. r=#thunderbird-reviewers

[Triage Comment]
Approved for beta

The mozilla-beta patch just approved for uplift should be available in the pinned Firefox beta 4

Comment 14

[Rob Lemley [:rjl]]

Thunderbird 115.0b2:
https://hg.mozilla.org/releases/comm-beta/rev/98ade1ec4ead