1817867 - `Restore Column Order` of thread pane doesn't do anything

Status: RESOLVED FIXED

(Thunderbird :: Folder and Message Lists, defect)

Description

[Thomas D. (:thomas8)]

112.0a1 (2023-02-20) (64-bit)

Thread pane columns on IMAP were acting up, showing wrong set of columns in wrong order (all small columns in front, as in bug 1612055), and thread column gone (restorable). So I tried "Restore Column Order", which did nothing.

If anyone can reproduce, kindly let me know.

STR

• Hide and show some columns of threadpane (e.g. Correspondents) from column picker, so that you don't have the default set. We need a non-default column order - for me it just happened, not sure how to force that as we cannot reorder columns yet.
• From column picker, choose "Restore Column Order".

Actual

• Nothing

Expected

• Reorder all chosen columns in default order

Btw: Why don't we have "Restore default set of columns"??

Comment 1

[Alessandro Castellani [:aleca]]

I can't reproduce this bug.
Clicking "Restore column order" works for me.

EDIT: Nevermind, I was able to reproduce it.
This used to work since I implemented it, something regressed it recently.
I'm also working on re-enabling the tests for this so we can hopefully avoid further breakages.

Comment 2

[Alessandro Castellani [:aleca]]

Regressed by this: https://hg.mozilla.org/comm-central/rev/fc209ade4484eade840c0887d8de49e9a7adc0a0#l1.899

Comment 3

[Alessandro Castellani [:aleca]]

Attachment: Bug 1817867 - Fix the restore column order options. r=darktrojan

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/comm-central/rev/e961caf59301
Fix the restore column order options. r=darktrojan

Comment 5

[Wayne Mery (:wsmwk)]

Comment on attachment 9318855 [details]
Bug 1817867 - Fix the restore column order options. r=darktrojan

[Triage Comment]
Approved for beta

Comment 6

[Daniel Darnell [:dandarnell]]

Thunderbird 111.0b2:
https://hg.mozilla.org/releases/comm-beta/rev/25d57964702c