Closed Bug 1817947 Opened 3 years ago Closed 3 years ago

Display extension (browser_)actions in unified toolbar

Categories

(Thunderbird :: Add-Ons: Extensions API, task)

Thunderbird 111
task

Tracking

(thunderbird111 wontfix, thunderbird112 fixed)

RESOLVED FIXED
112 Branch
Tracking Status
thunderbird111 --- wontfix
thunderbird112 --- fixed

People

(Reporter: freaktechnik, Assigned: freaktechnik)

References

Details

(Whiteboard: [Supernova3p])

Attachments

(1 file)

The unified toolbar is replacing the mail tab toolbar. As such, we need to add extension browser actions (or just actions in mv3) to the unified toolbar. The benefit of this is that we can offer easy access to other tabs, since the unified toolbar is always visible in the main window.

As a first step, this restores the extension buttons in the unified toolbar. The following features are tackled in this task:

  • Add button to the end of the toolbar, in both the default state and the current state of the mail space
  • Show the extension provided icon on the button (depends on tab)
  • Show the extension provided label (depends on tab)
  • Set the extension provided title (depends on tab)
  • Show the extension provided badge (depends on tab)
  • Execute the click handling when the button is clicked (show popup/fire onClicked)
  • Remove the button when the extension is uninstalled
  • Gracefully handle the extension being disabled

All this while preserving the functionality in the message viewer window, where the mail toolbar still exists.

We will not support adding buttons to the tab bar anymore, however.

Blocks: 1817948
Blocks: 1817949
Blocks: 1817951
Blocks: 1817952
Attachment #9318984 - Attachment description: WIP: Bug 1817947 - Unified toolbar extension integration POC. r=john.bieling,aleca → WIP: Bug 1817947 - Initial unified toolbar extension action integration. r=john.bieling,aleca
Attachment #9318984 - Attachment description: WIP: Bug 1817947 - Initial unified toolbar extension action integration. r=john.bieling,aleca → Bug 1817947 - Initial unified toolbar extension action integration. r=john.bieling,aleca
Attachment #9318984 - Attachment description: Bug 1817947 - Initial unified toolbar extension action integration. r=john.bieling,aleca → Bug 1817947 - Initial unified toolbar extension action integration. r=#thunderbird-reviewers,aleca
Target Milestone: --- → 112 Branch

Pushed by alessandro@thunderbird.net:
https://hg.mozilla.org/comm-central/rev/05b89a2c6573
Initial unified toolbar extension action integration. r=aleca

Status: ASSIGNED → RESOLVED
Closed: 3 years ago
Resolution: --- → FIXED
Blocks: 1819317

Martin, do you want this on beta 111 and the three bugs fixed thus far, or let them all ride the train to 112?

Flags: needinfo?(martin)

I would suggest letting this ride the train for now. I doesn't quite behave right (see bug 1819317) yet, which I think just makes it less well suited to be uplifted to beta.

Flags: needinfo?(martin)
Whiteboard: [supernova] → [Supernova3p]
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: