1818054 - Vimeo captions do not display in PiP window

Status: RESOLVED FIXED

(Toolkit :: Picture-in-Picture, defect, P2)

Description

[Brad Dougherty]

Tested in nightly 112.0a1 (2023-02-21):

1. Go to https://player.vimeo.com/embed
2. Enable any of the captions by using the CC button in the player
3. Play the video
4. Hit the Picture-in-Picture button

The PiP window should display those captions, but it does not.

The Vimeo player uses WebVTT files specified in <track> elements with the mode set to "hidden" for our custom display.

After some investigation, it looks like our issue here is that the setActiveTextTrack() function is checking for mode to be "showing" in order to consider a track active. PictureInPictureChild.jsm:setActiveTextTrack (called from PictureInPictureChild.jsm:setupTextTracks)

I confirmed that manually switching the track from "hidden" to "showing" results in the captions displaying properly in the PiP window.

We are happy to make changes to our player to get this working, but we can't universally change the mode to "showing". In other browsers, we do this in the player on enterpictureinpicture, but as far as I know, there is no equivalent for us to use in Firefox.

Comment 1

[Ania]

Hi,
We will add support for hidden mode, so Vimeo subs will be visible in Picture-in-Picture, no changes are necessary from your side.
We can't promise the exact release, but this is high on our backlog list.

Comment 2

[(spammer)]

Attachment: (spam)

Here are my melons photography you f00ls!

Comment 3

[(spammer)]

Attachment: (spam)

And this is my lovely husband

Comment 4

[:glob ✱]

The content of attachment 9344806 [details] has been deleted for the following reason:

Spam

Comment 5

[:glob ✱]

The content of attachment 9344805 [details] has been deleted for the following reason:

Spam

Comment 6

[joanrandall]

The statement "Vimeo captions do not display in Pip (Picture-in-Picture) window" indicates that when you use Picture-in-Picture mode while watching a <a href="https://todaan.com/">captions</a> for images on Vimeo, the closed captions or subtitles are not visible in the smaller, floating video window. This can be a limitation of the Vimeo platform or the specific video player being used, as not all video players support displaying captions in the Pip mode. Users who rely on captions for accessibility may find this issue inconvenient and may need to watch the video in the standard Fullscreen mode to access the captions.

Comment 7

[Joseph Webster]

Attachment: Bug 1818054 - Display PiP captions in Vimeo player r=kpatenio

Comment 8

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/93c467e711d4
Display PiP captions in Vimeo player r=pip-reviewers,niklas

Comment 9

[Cosmin Sabou [:CosminS]]

https://hg.mozilla.org/mozilla-central/rev/93c467e711d4