1818085 - Give user a choice on how open in app works

Status: RESOLVED FIXED

(Firefox for Android :: General, enhancement, P2)

Description

[Roger Yang [:royang]]

Attachment: Example

Allow user to choose if they want to be prompted every time when there's a link that can be opened in an app.

We should give user three choices:

1. Ask every time
2. Always
3. Never

Comment 4

[Roger Yang [:royang]]

Attachment: Screenshot_20230228_182625.png

Comment 5

[Roger Yang [:royang]]

@jpfaller, please take a look at the screenshot and let me know if the strings are OK for the new dialog in settings.

Comment 6

[BMO Automation]

Attachment: [mozilla-mobile/firefox-android] Bug 1818085 - Add preference to allow user to choose how open links in app works (#1054)

Comment 7

[Emily Wachowiak [:emilyw]]

Hi Roger. Jeff passed this to me so I'm taking a look. I'm curious why this setting is using a dialog and not a sub-page in settings. I couldn't find any other settings that used a dialog like this. Is there a specific reason why we wouldn't create a subpage? Thanks.

Comment 8

[Tiffanie Shakespeare [:tif]]

clearing Jeff's NI

Comment 9

[Emily Wachowiak [:emilyw]]

Roger, Tif told me that you're going to change this from a dialog to a setting sub-page to match the rest of the settings UX. Excellent.

Here are my strings (in the order they should appear):
Open links in apps

• Always
• Ask before opening
• Never

Comment 10

[Roger Yang [:royang]]

(In reply to Emily Wachowiak [:emilyw] from comment #9)

Roger, Tif told me that you're going to change this from a dialog to a setting sub-page to match the rest of the settings UX. Excellent.

Here are my strings (in the order they should appear):
Open links in apps

• Always
• Ask before opening
• Never

Thanks, I"ll update the strings.

Comment 11

[Roger Yang [:royang]]

Attachment: Screenshot_20230302_221342.png

Comment 12

[Ryan VanderMeulen [:RyanVM]]

This was fixed for v112.
https://github.com/mozilla-mobile/firefox-android/commit/54ac5744ad71588818ebd10a98c0fd8c5d683fd3

Comment 13

[Delia Pop (Android QA)]

Verified as fixed in Nightly 113.0a1 from 03/23 and Beta 112.0b5. The "Open links in apps" settings menu is displayed with the 3 options available (Always, Ask before opening, Never) and they work as expected.
Tested with:

• Google Pixel 6 (Android 13)
• Lenovo Yoga Tab 11 (Android 11)
• LG G7 fit (Android 8.1.0)

Comment 14

[Chris Peterson [:cpeterson]]

AFAICT, we can't uplift this fix to a 111 dot release because it adds new strings, which may not have been localized in Beta 112 yet.

Comment 15

[Delia Pop (Android QA)]

Verified as fixed in Beta 112.0b6 as well.