1818170 - Add support for actions to gn_processor.py

Status: RESOLVED FIXED

(Core :: WebRTC, task, P1)

Description

[Andreas Pehrson [:pehrsons]]

libwebrtc M109 has added an action to generate a header with a python script in https://webrtc.googlesource.com/src/+/64a33f24536dd988db43bd567417be954e948218.

The most future proof way forward might be to add support to gn_processor.py to convert BUILD.gn file-generating actions to moz.build GeneratedFile entries.

Comment 1

[Andreas Pehrson [:pehrsons]]

Attachment: Bug 1818170 - Make gn_processor.py handle actions that generate files. r?glandium!

Comment 2

[Andreas Pehrson [:pehrsons]]

Attachment: Bug 1818170 - Allow files generated during libwebrtc build in LOCAL_INCLUDES. r?glandium!

Comment 3

[Andreas Pehrson [:pehrsons]]

Attachment: Bug 1818170 - Generate libwebrtc moz.build files. r?mjf!

Comment 4

[Andreas Pehrson [:pehrsons]]

Attachment: Bug 1818170 - In gn_processor.py pretty print lists when serializing. r?glandium!

Comment 5

[Andreas Pehrson [:pehrsons]]

Attachment: Bug 1818170 - Load python files directly with our python. r?glandium!

This ignores the shebang in python scripts that would be used when executed
directly.

This is unfortunate but needed as libwebrtc/chromium scripts rely on vpython3.

Comment 6

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/a97b93e3f440
Make gn_processor.py handle actions that generate files. r=glandium
https://hg.mozilla.org/integration/autoland/rev/1e99346a4ac8
Allow files generated during libwebrtc build in LOCAL_INCLUDES. r=glandium
https://hg.mozilla.org/integration/autoland/rev/1dba81a003b9
In gn_processor.py pretty print lists when serializing. r=glandium
https://hg.mozilla.org/integration/autoland/rev/4034a59aa9a8
Generate libwebrtc moz.build files. r=mjf,ng,webrtc-reviewers
https://hg.mozilla.org/integration/autoland/rev/09408cd729c1
Load python files directly with our python. r=glandium

Comment 7

[Serban Stanca [:SerbanS]]

https://hg.mozilla.org/mozilla-central/rev/a97b93e3f440
https://hg.mozilla.org/mozilla-central/rev/1e99346a4ac8
https://hg.mozilla.org/mozilla-central/rev/1dba81a003b9
https://hg.mozilla.org/mozilla-central/rev/4034a59aa9a8
https://hg.mozilla.org/mozilla-central/rev/09408cd729c1