Closed Bug 1818170 Opened 2 years ago Closed 2 years ago

Add support for actions to gn_processor.py

Categories

(Core :: WebRTC, task, P1)

task

Tracking

()

RESOLVED FIXED
112 Branch
Tracking Status
firefox112 --- fixed

People

(Reporter: pehrsons, Assigned: pehrsons)

References

Details

Attachments

(5 files)

libwebrtc M109 has added an action to generate a header with a python script in https://webrtc.googlesource.com/src/+/64a33f24536dd988db43bd567417be954e948218.

The most future proof way forward might be to add support to gn_processor.py to convert BUILD.gn file-generating actions to moz.build GeneratedFile entries.

This ignores the shebang in python scripts that would be used when executed
directly.

This is unfortunate but needed as libwebrtc/chromium scripts rely on vpython3.

Pushed by pehrsons@gmail.com: https://hg.mozilla.org/integration/autoland/rev/a97b93e3f440 Make gn_processor.py handle actions that generate files. r=glandium https://hg.mozilla.org/integration/autoland/rev/1e99346a4ac8 Allow files generated during libwebrtc build in LOCAL_INCLUDES. r=glandium https://hg.mozilla.org/integration/autoland/rev/1dba81a003b9 In gn_processor.py pretty print lists when serializing. r=glandium https://hg.mozilla.org/integration/autoland/rev/4034a59aa9a8 Generate libwebrtc moz.build files. r=mjf,ng,webrtc-reviewers https://hg.mozilla.org/integration/autoland/rev/09408cd729c1 Load python files directly with our python. r=glandium
Regressions: 1823058
Regressions: 1826023
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: