Failure on macOS running './mach python python/mozbuild/mozbuild/gn_processor.py dom/media/webrtc/third_party_build/gn-configs/webrtc.json'
Categories
(Core :: WebRTC, defect, P2)
Tracking
()
Tracking | Status | |
---|---|---|
firefox-esr102 | --- | unaffected |
firefox111 | --- | unaffected |
firefox112 | --- | wontfix |
firefox113 | --- | fixed |
People
(Reporter: mjf, Assigned: pehrsons)
References
(Regression)
Details
(Keywords: regression)
Attachments
(1 file)
This works on linux, but fails on both my macOS machines (Intel and Apple Silicon running 12.6.3 Monterey) with:
Traceback (most recent call last):
File "/Users/mfroman/mozilla/moz-central/python/mozbuild/mozbuild/gn_processor.py", line 776, in <module>
main()
File "/Users/mfroman/mozilla/moz-central/python/mozbuild/mozbuild/gn_processor.py", line 765, in main
write_mozbuild(
File "/Users/mfroman/mozilla/moz-central/python/mozbuild/mozbuild/gn_processor.py", line 600, in write_mozbuild
mb.write_attrs(common_attrs)
File "/Users/mfroman/mozilla/moz-central/python/mozbuild/mozbuild/gn_processor.py", line 81, in write_attrs
self.write_mozbuild_dict(k, v)
File "/Users/mfroman/mozilla/moz-central/python/mozbuild/mozbuild/gn_processor.py", line 122, in write_mozbuild_dict
for o in value["outputs"]:
KeyError: 'outputs'
I reverted the changes from Bug 1818170 and it doesn't fail (of course, it removes all the changes from the moz.build files that Bug 1818170 added).
Reporter | ||
Updated•2 years ago
|
Comment 2•2 years ago
|
||
Set release status flags based on info from the regressing bug 1818170
Assignee | ||
Updated•2 years ago
|
Assignee | ||
Updated•2 years ago
|
Assignee | ||
Comment 3•2 years ago
|
||
On Mac, /var is a symlink to /private/var, so if a path passed to
mozpath.relpath starts with /var, but the startdir passed to the same function
starts with /private/var, we get into problems.
The issue in bug 1826023 happened when figuring out a relative path to a
generated file, which given the situation above would become
'../../../../../../private/var/folders/pg/ns3y3qkj5wx1zm_wdgp5wsm40000gn/T/tmpxogmvo36/gen/experiments/registered_field_trials.h'.
Making sure the startdir path is resolved, solves this problem.
Comment 5•2 years ago
|
||
bugherder |
Assignee | ||
Updated•2 years ago
|
Description
•