1818356 - --panel-description-color is currently using system color GrayText reserved for disabled items only

Status: RESOLVED FIXED

(Firefox :: Theme, defect, P2)

Description

[Jules Simplicio [:jules]]

global-shared.css currently sets --panel-description-color to GrayText. Accessibility recommends we reserve GrayText for disabled or placeholder items only.

Comment 1

[Amy Churchwell [:amy]]

Hey Jules, do you have a recommendation for what color we should use here instead?

Comment 2

[Jules Simplicio [:jules]]

Hey Amy, last time I spoke to Dao about this he recommended inherit since panels already have a color set. Thanks for asking, I forgot to include that.

Comment 3

[Sam Foster [:sfoster] (he/him)]

Looks like we use GreyText and a hsl grey hsl(0,0%,50%); for MacOS. I assume we want to update both? (By removing the MacOS override)
Assigning P2 to this - its a simple patch and a11y issue we should get to sooner rather than later.

Comment 4

[Jules Simplicio [:jules]]

Thanks, Sam. Yes, we should update both places.

Comment 5

[Dão Gottwald [:dao]]

(In reply to Sam Foster [:sfoster] (he/him) from comment #3)

Looks like we use GreyText and a hsl grey hsl(0,0%,50%); for MacOS. I assume we want to update both? (By removing the MacOS override)
Assigning P2 to this - its a simple patch and a11y issue we should get to sooner rather than later.

Yeah, we should use something like color-mix(in srgb, currentColor 70%, transparent) instead of GrayText on all platforms when not in HCM, and inherit in HCM.

Comment 6

[Dão Gottwald [:dao]]

Attachment: Bug 1818356 - Clean up --panel-description-color and --panel-disabled-color. r=sfoster

Comment 7

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/24f45b99ed08
Clean up --panel-description-color and --panel-disabled-color. r=sfoster

Comment 8

[Serban Stanca [:SerbanS]]

https://hg.mozilla.org/mozilla-central/rev/24f45b99ed08