1818495 - Use location source and sourceActor attribute instead of re-querying the selectors.

Status: RESOLVED FIXED

(DevTools :: Debugger, task)

Description

[Alexandre Poirot [:ochameau]]

Bug 1815500 will start exposing source and sourceActor objects on all location objects.
We could then migrate all code using getLocationSource(getState, location) to location.source.
And also migrate many other code pattern doing the similar thing: query the selectors to map sourceId to the source actor.

A similar simplication is also possible for sourceActorId versus sourceActor.

Comment 2

[Alexandre Poirot [:ochameau]]

Attachment: Bug 1818495 - [devtools] Use location source and sourceActor attribute instead of re-querying the selectors.

This may keep running async code whose source have been removed,
but this help remove various selectors lookups.

If we expect to check in async code if the source is still registered,
we should probably have an explicit API for this.

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/b54d15de5072
[devtools] Use location source and sourceActor attribute instead of re-querying the selectors. r=bomsy,devtools-reviewers

Comment 4

[Serban Stanca [:SerbanS]]

https://hg.mozilla.org/mozilla-central/rev/b54d15de5072