1824375 - Error when clicking on an item in the source tree

Status: VERIFIED FIXED

(DevTools :: Debugger, defect)

Description

[Nicolas Chevobbe [:nchevobbe]]

1. Go to https://nchevobbe.github.io/demo/console-test-app.html
2. Open the debugger
3. In the source tree, select webpack:///node_modules/react-dom/cjs/react-dom.development.js

-> I get an error in the browser console:

JavaScript error: resource://devtools/client/shared/prefs.js, line 90: NS_ERROR_ILLEGAL_VALUE: Component returned failure code: 0x80070057 (NS_ERROR_ILLEGAL_VALUE) [nsIPrefBranch.setStringPref]

The value we are trying to set is huge (1073868 chars), bigger than the max one (https://searchfox.org/mozilla-central/rev/6fc2f6d5335fb6f70f780b5fea5ed77b0719c3b5/modules/libpref/Preferences.cpp#162)

The pref is debugger.pending-selected-location and seems to hold a whole sourceMap file, which is defined as dataURL, probably explaining the exception

Comment 1

[Hubert Boma Manilla (:bomsy)]

Looks like a recent regression.

Comment 2

[Alice0775 White]

Regression window:
https://hg.mozilla.org/integration/autoland/pushloghtml?fromchange=7f4d99410d0026d3664d70703043d710afe16e5e&tochange=b54d15de5072cd0e289d9a5331dd20d65773a8fb

Regressed by either Bug 1818495 or Bug 1815500.

Comment 3

[BugBot [:suhaib / :marco/ :calixte]]

Set release status flags based on info from the regressing bug 1818495

:ochameau, since you are the author of the regressor, bug 1818495, could you take a look? Also, could you set the severity field?

For more information, please visit auto_nag documentation.

Comment 4

[BugBot [:suhaib / :marco/ :calixte]]

Set release status flags based on info from the regressing bug 1818495

Comment 5

[Alexandre Poirot [:ochameau] [PTO back August 21]]

It was regressed by bug 1815500, which introduced the source attribute in all location objects, which we ended trying to save in a pref over there:
https://searchfox.org/mozilla-central/rev/31f5847a4494b3646edabbdd7ea39cb88509afe2/devtools/client/debugger/src/reducers/sources.js#95-101

      location = {
        ...action.location,
        url: action.source.url,
      };

      if (action.source.url) {
        prefs.pendingSelectedLocation = location;
      }

action.location is a regular location object.

Comment 6

[Alexandre Poirot [:ochameau] [PTO back August 21]]

Attachment: Bug 1824375 - [devtools] Avoid saving locations as pending locations.

location and pending location are different types of objects.
Pending location is having only three attributes: url, line and column.
Where location rather expose source, sourceActor and line and column.

The source object was problematic here as it is large and couldn't be saved into a pref.

Comment 7

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/38967ad7e8f2
[devtools] Avoid saving locations as pending locations. r=devtools-reviewers,bomsy

Comment 8

[Sandor Molnar[:smolnar]]

https://hg.mozilla.org/mozilla-central/rev/38967ad7e8f2

Comment 9

[BugBot [:suhaib / :marco/ :calixte]]

The patch landed in nightly and beta is affected.
:ochameau, is this bug important enough to require an uplift?

• If yes, please nominate the patch for beta approval.
• If no, please set status-firefox113 to wontfix.

For more information, please visit auto_nag documentation.

Comment 10

[Alexandre Poirot [:ochameau] [PTO back August 21]]

Comment on attachment 9329545 [details]
Bug 1824375 - [devtools] Avoid saving locations as pending locations.

Beta/Release Uplift Approval Request

• User impact if declined: Some sources with some particular usages of SourceMaps can't be selected. When selecting them, a new tab is opened but you can't focus it.
• Is this code covered by automated tests?: Yes
• Has the fix been verified in Nightly?: No
• Needs manual test from QE?: Yes
• If yes, steps to reproduce: * Go to https://nchevobbe.github.io/demo/console-test-app.html
• Open the debugger
• In the source tree, select webpack:///node_modules/react-dom/cjs/react-dom.development.js

AR: a new tab is opened for reac-dom-development.js, but it is empty or not focusable. In any case, you can't see the sources for this file.

ER: The source displays fine.

• List of other uplifts needed: None
• Risk to taking this patch: Low
• Why is the change risky/not risky? (and alternatives if risky): Only impacts the debugger. Has been written conservatively.
• String changes made/needed: no
• Is Android affected?: No

Comment 11

[Ryan VanderMeulen [:RyanVM]]

Comment on attachment 9329545 [details]
Bug 1824375 - [devtools] Avoid saving locations as pending locations.

Approved for 113.0b8.

Comment 12

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/releases/mozilla-beta/rev/c49d9524146a

Comment 13

[Hani Yacoub, Desktop QA]

Verified as fixed on Window 10 x64, macOS 11.6 and on Ubuntu 20.04 x64.

Comment 14

[Hani Yacoub, Desktop QA]

Verified as fixed on Window 10 x64, macOS 11.6 and on Ubuntu 20.04 x64 on Firefox 113.0b8.