1818802 - Update strings in the ETP settings screen - Part 1: Add new strings only

Status: RESOLVED FIXED

(Fenix :: Privacy, defect, P2)

Description

[Chris Peterson [:cpeterson]]

Attachment: Figma_screenshot.png

See the attached screenshot of the Figma design: https://www.figma.com/file/OUOpOzgd4EOdgwJZvBGQ9j/TCP?node-id=248%3A13722&t=FLNdFvUmBgF5QQKq-4

Comment 1

[Chris Peterson [:cpeterson]]

Attachment: Current_ETP_settings_screenshot.jpg

Screenshot of the current ETP settings screen. These strings need to be replaced:

• Browse without being followed -> removed

• Keep your data to yourself. Firefox protects you from many of the most common trackers that follow what you do online. -> Firefox protects you from many of the most common trackers that follow what you do online.

• Learn more > -> Learn more without > arrow

• Remove shield icon from the Enhanced Tracking Protection sub-header.

• Add Now featuring Total Cookie Protection, our most powerful barrier yet against cross-site trackers.

• Balanced for privacy and performance. Pages load normally. -> Pages will load normally, but block fewer trackers.

• Blocks more trackers so pages load faster, but some on-page functionality may break. -> Stronger tracking protection and faster performance, but some sites may not work properly.

• The Figma design accidentally omitted the "Exceptions" menu. The "Exceptions" menu should stay!

Comment 2

[Chris Peterson [:cpeterson]]

Attachment: Figma_screenshot.png

Comment 3

[Chris Peterson [:cpeterson]]

We’re shipping TCP in v111, so it would be nice to fix these ETP settings strings soon because people will be looking at them. We can’t uplift new strings to Beta v111, so v112 is the soonest we could fix this bug.

We will need to update the screenshots in the SUMO article about ETP settings:

https://support.mozilla.org/en-US/kb/enhanced-tracking-protection-firefox-android

Comment 4

[BMO Automation]

Attachment: [mozilla-mobile/firefox-android] Bug 1818802 - WIP Update strings in the ETP settings screen (#1134)

Comment 5

[twhite]

[:cpeterson] The UI design for the update has changed the height of the background image.

• Does this height need updating to match the UI design?
• Where does the updated vector design come from - do I need modify the existing vector or is it provided?
• Where it say “Firefox protects…” should this be dependant on build type? e.g. “Firefox Nightly protects…”

Comment 6

[Chris Peterson [:cpeterson]]

(In reply to twhite from comment #5)

[:cpeterson] The UI design for the update has changed the height of the background image.

• Does this height need updating to match the UI design?
• Where does the updated vector design come from - do I need modify the existing vector or is it provided?

I don't know, so I asked the UX designer.

• Where it say “Firefox protects…” should this be dependant on build type? e.g. “Firefox Nightly protects…”

Yes. I think references to "Firefox" in our UI are supposed to use the Firefox and channel name. I think there is a convenient string constant for this, but I don't know what it is. You'll have to ask another Android engineer.

However, I see some hard coded uses of "Firefox" in strings.xml. Someone should probably clean those up in a different bug, but it's not a high priority.

Comment 7

[twhite]

[:cpeterson] thank you for the info. I've also reached out to the UX who are providing some guidance. They confirmed, it should display the full product name, e.g. Firefox Nightly...