1818927 - Clean-up scrollbars / in-content XUL set-up.

Status: RESOLVED FIXED

(Core :: CSS Parsing and Computation, task)

Comment 1

[Emilio Cobos Álvarez (:emilio)]

Attachment: Bug 1818927 - Move scrollbar-related rules from minimal-xul.css to scrollbars.css. r=dholbert

No behavior change, both these sheets get loaded in all pages
unconditionally, and the new order matches the order they get
loaded in.

Depends on D170945

Comment 2

[Emilio Cobos Álvarez (:emilio)]

Attachment: Bug 1818927 - Minor consistency improvements in scrollbars.css. r=dholbert

No behavior change, just cleanup.

Depends on D171008

Comment 3

[Emilio Cobos Álvarez (:emilio)]

Attachment: Bug 1818927 - Remove unused rule from scrollbars.css. r=dholbert

value="hidden" is never set by native code on a scrollbar.

Depends on D171009

Comment 4

[Emilio Cobos Álvarez (:emilio)]

Attachment: Bug 1818927 - Remove XUL clickthrough attribute. r=dholbert

It only has an effect on macOS, and it's only used for
scrollbars/resizers/trees. We already hard-coded <browser>
to behave as never so do the same consistently, see bug 1519905.

This reduces noise when inspecting scrollbars (and it's simpler).

No behavior change.

Depends on D171010

Comment 5

[Emilio Cobos Álvarez (:emilio)]

Attachment: Bug 1818927 - Remove minimal-xul.css. r=dholbert

No longer needed.

Depends on D171011

Comment 6

[Emilio Cobos Álvarez (:emilio)]

Attachment: Bug 1818927 - Don't use collapsed attribute to hide thumb. r=dholbert

Explicitly set visibility on the thumb instead. This will help to remove
the thumb element altogether, potentially (and it's simpler anyhow).

Depends on D171012

Comment 7

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/f50bb20ae41d
Move scrollbar-related rules from minimal-xul.css to scrollbars.css. r=dholbert
https://hg.mozilla.org/integration/autoland/rev/08ad4bea30d6
Minor consistency improvements in scrollbars.css. r=dholbert
https://hg.mozilla.org/integration/autoland/rev/4f944842cde4
Remove unused rule from scrollbars.css. r=dholbert
https://hg.mozilla.org/integration/autoland/rev/0f0342ee4149
Remove XUL clickthrough attribute. r=dholbert
https://hg.mozilla.org/integration/autoland/rev/6cf817fdd398
Remove minimal-xul.css. r=dholbert
https://hg.mozilla.org/integration/autoland/rev/02c5f8c116b5
Don't use collapsed attribute to hide thumb. r=dholbert

Comment 8

[Norisz Fay [:noriszfay]]

Backed out for causing bc failurs on browser_parsable_css.js

Backout link

Push with failures

Failure log

Comment 9

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/2f81e12a3626
Move scrollbar-related rules from minimal-xul.css to scrollbars.css. r=dholbert
https://hg.mozilla.org/integration/autoland/rev/1bcd0983afcd
Minor consistency improvements in scrollbars.css. r=dholbert
https://hg.mozilla.org/integration/autoland/rev/cd2712d1fa42
Remove unused rule from scrollbars.css. r=dholbert
https://hg.mozilla.org/integration/autoland/rev/c30a1ed7efb2
Remove XUL clickthrough attribute. r=dholbert
https://hg.mozilla.org/integration/autoland/rev/d1fa7a4517e6
Remove minimal-xul.css. r=dholbert
https://hg.mozilla.org/integration/autoland/rev/02e611cd540a
Don't use collapsed attribute to hide thumb. r=dholbert

Comment 10

[Cristina Horotan [:chorotan]]

https://hg.mozilla.org/mozilla-central/rev/2f81e12a3626
https://hg.mozilla.org/mozilla-central/rev/1bcd0983afcd
https://hg.mozilla.org/mozilla-central/rev/cd2712d1fa42
https://hg.mozilla.org/mozilla-central/rev/c30a1ed7efb2
https://hg.mozilla.org/mozilla-central/rev/d1fa7a4517e6
https://hg.mozilla.org/mozilla-central/rev/02e611cd540a

Comment 11

[Alessandro Castellani [:aleca]]

Attachment: Port Bug 1818927 - Remove minimal-xul.css. r=#thunderbird-reviewers

Comment 12

[Phabricator Automation]

Comment on attachment 9320115 [details]
Port Bug 1818927 - Remove minimal-xul.css. r=#thunderbird-reviewers

Revision D171150 was moved to bug 1819183. Setting attachment 9320115 [details] to obsolete.