1818992 - Lower Mesa requirement for X11 EGL to match WebRender's Mesa requirements

Status: RESOLVED FIXED

(Core :: Graphics, task, P3)

Description

[Andrew Osmond [:aosmond] (he/him)]

This would allow us to capture most users left on GLX (besides old NVIDIA drivers) and avoid issues seen only with GLX.

Comment 1

[Andrew Osmond [:aosmond] (he/him)]

We appear to have users on nightly still with Mesa 19 and 20. These combined represent about 6-7% of users in release. 29% and 4% in nightly respectively (these figures are a bit surprising to me given nightly is the reverse of release, maybe it is an automated testing distortion?).

Comment 2

[Andrew Osmond [:aosmond] (he/him)]

try: https://treeherder.mozilla.org/jobs?repo=try&revision=1406ce83f5fd5a33b44ace0c461b81942e98ff32

Bug 1695933 comment 2 and bug 1695933 comment 9 implied there were test failures two years ago, specifically around asan.

Comment 3

[Darkspirit]

• bug 1709584 blocked enabling EGL/X11 in Ubuntu 18.04 CI.
• FEATURE_DMABUF (bug 1572697): No problems known yet.
• WR/Xwayland could be lowered as well.
  • partial present (supported on X11&Xwayland since Mesa 20.2) would cause bug 1677892 on Xwayland < 1.20.10.
    • Requiring Mesa 21 for partial present on Xwayland wouldn't hurt, but also wouldn't help if a user would manually compile latest Mesa on Ubuntu 18.04.
    • Ubuntu, Debian and Fedora don't seem to have affected package version combinations anymore.
      18.04 LTS (EOL April 2028 ... )=unaffected:
      https://packages.ubuntu.com/bionic-updates/xwayland 1.19.6 - affected if Mesa would be >=20.2
      https://packages.ubuntu.com/bionic-updates/libegl-mesa0 20.0.8
      20.10=unaffected:
      https://packages.ubuntu.com/focal/xwayland 1.20.13 unaffected
      https://packages.ubuntu.com/focal/libegl-mesa0 21.2.6
      unaffected:
      https://packages.debian.org/stable/xwayland 1.20.11 unaffected
      https://packages.debian.org/stable/libegl-mesa0 20.3.5
      irrelevant:
      https://packages.debian.org/oldstable/xwayland 1.20.4 - affected if Mesa would be >=20.2
      https://packages.debian.org/oldstable/libegl-mesa0 18.3.6

Comment 4

[Andrew Osmond [:aosmond] (he/him)]

Yep I am going to skip the blocking test in bug 1709584 for this to land. We seem confident it isn't an actual problem in Firefox and we know there are already many other issues with us using GLX that EGL solves.

Comment 5

[Andrew Osmond [:aosmond] (he/him)]

Updating the title / goal to ship EGL where ever we have chosen to ship WebRender with Mesa. That way we never should use GLX unless it is with SWGL / on really old targets. This means we are targeting 17+ in general, and 18.2+ for nouveau.

Comment 6

[Andrew Osmond [:aosmond] (he/him)]

Attachment: Bug 1818992 - Ship X11 EGL on Mesa 17+ to match WebRender.

When we initially shipped X11 EGL on Mesa 21+, it was chosen
specifically to avoid CI issues. These appear to have mostly been
resolved with minimal annotations required to enable EGL on release.
This will allow the majority of Linux Mesa users to switch away from
GLX.

With this patch, we will match shipping X11 EGL on where we chose to
ship WebRender. Specifically that is Mesa 17+ in general, and 18.2+ for
Nouveau.

Comment 7

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/f2cee2116b0b
Ship X11 EGL on Mesa 17+ to match WebRender. r=webdriver-reviewers,gfx-reviewers,whimboo,lsalzman

Comment 8

[Serban Stanca [:SerbanS]]

https://hg.mozilla.org/mozilla-central/rev/f2cee2116b0b