Closed Bug 1819091 Opened 3 years ago Closed 3 years ago

[wpt-sync] Sync PR 38722 - Make table columns stop using `LayoutBox::SetLogical{Width,Height}`

Categories

(Core :: Layout, task, P4)

Product:
Core
Component:
Layout
Type:
task

Tracking

()

Status:
RESOLVED FIXED
Milestone:
114 Branch
Tracking Flags:
Tracking Status
firefox114 --- fixed

People

(Reporter: wpt-sync, Unassigned)

References

(Blocks 1 open bug,
URL
)

Details

(Whiteboard: [wptsync downstream])

Sync web-platform-tests PR 38722 into mozilla-central (this bug is closed when the sync is complete).

PR: https://github.com/web-platform-tests/wpt/pull/38722
Details from upstream follow.

Andreu Botella <abotella@igalia.com> wrote:

Make table columns stop using LayoutBox::SetLogical{Width,Height}

Table columns and column groups don't need to be laid out, but they
have associated LayoutBox objects, and they have a size that can be
queried with col.offset{Height,Width}. This is achieved without
laying them out by calling LayoutBox::SetLogical{Width,Height}.
These methods, however, are being removed as part of the NoCopyBack
project.

This change instead makes LayoutNGTableColumn override
LayoutBox::Size to provide a size that can be set through methods
defined in LayoutNGTableColumn, independent of LayoutBox. The
change also makes col.offset{Top,Left} work (by overriding
LayoutBox::Location) and makes sure that "out of bounds" columns and
colgroups (that is, columns and colgroup boxes which don't correspond
to any actual column in the table) have offset values that make sense.

Bug: 1371882
Change-Id: I3dae24122479730af1841f09405a4d33694f1972
Reviewed-on: https://chromium-review.googlesource.com/4290876
WPT-Export-Revision: a2513fc6347b70da5002828d2558b09fccb57117

Component: web-platform-tests → Layout
Product: Testing → Core
Whiteboard: [wptsync downstream] → [wptsync downstream error]
Whiteboard: [wptsync downstream error] → [wptsync downstream]

CI Results

Ran 9 Firefox configurations based on mozilla-central, and Firefox, Chrome, and Safari on GitHub CI

Total 3 tests and 17 subtests

Status Summary

Firefox

OK : 3
PASS: 28
FAIL: 23

Chrome

OK : 3
PASS: 36
FAIL: 15

Safari

OK : 3
PASS: 19
FAIL: 32

Links

Gecko CI (Treeherder)
GitHub PR Head
GitHub PR Base

Details

Firefox-only Failures

New Tests That Don't Pass

  • /css/css-break/table/table-parts-offsets-vertical-lr.tentative.html [wpt.fyi]
    • row2: FAIL (Chrome: PASS, Safari: FAIL)
    • cell4: FAIL (Chrome: PASS, Safari: PASS)
    • content4: FAIL (Chrome: PASS, Safari: PASS)
  • /css/css-break/table/table-parts-offsets-vertical-rl.tentative.html [wpt.fyi]
    • table: FAIL (Chrome: PASS, Safari: PASS)
    • colgroup: FAIL (Chrome: FAIL, Safari: FAIL)
    • col: FAIL (Chrome: FAIL, Safari: FAIL)
    • col2: FAIL (Chrome: FAIL, Safari: FAIL)
    • colgroup2: FAIL (Chrome: FAIL, Safari: FAIL)
    • col3: FAIL (Chrome: FAIL, Safari: FAIL)
    • rowgroup: FAIL (Chrome: PASS, Safari: FAIL)
    • row: FAIL (Chrome: PASS, Safari: FAIL)
    • cell: FAIL (Chrome: PASS, Safari: FAIL)
    • content: FAIL (Chrome: PASS, Safari: FAIL)
    • cell2: FAIL (Chrome: PASS, Safari: FAIL)
    • content2: FAIL (Chrome: PASS, Safari: FAIL)
    • cell3: FAIL (Chrome: PASS, Safari: FAIL)
    • content3: FAIL (Chrome: PASS, Safari: FAIL)
    • row2: FAIL (Chrome: PASS, Safari: FAIL)
    • cell4: FAIL (Chrome: PASS, Safari: FAIL)
    • content4: FAIL (Chrome: PASS, Safari: FAIL)
  • /css/css-break/table/table-parts-offsets.tentative.html [wpt.fyi]
    • row2: FAIL (Chrome: PASS, Safari: FAIL)
    • cell4: FAIL (Chrome: PASS, Safari: PASS)
    • content4: FAIL (Chrome: PASS, Safari: PASS)
Pushed by wptsync@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/b14b8ae8eb8f [wpt PR 38722] - Make table columns stop using `LayoutBox::SetLogical{Width,Height}`, a=testonly https://hg.mozilla.org/integration/autoland/rev/ae70eda35161 [wpt PR 38722] - Update wpt metadata, a=testonly

https://hg.mozilla.org/mozilla-central/rev/b14b8ae8eb8f
https://hg.mozilla.org/mozilla-central/rev/ae70eda35161

Status: NEW → RESOLVED
Closed: 3 years ago
status-firefox114: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → 114 Branch
You need to log in before you can comment on or make changes to this bug.