Closed
Bug 1819124
Opened 2 years ago
Closed 2 years ago
Mark ReadableStream::CreateNative as MOZ_CAN_RUN_SCRIPT_BOUNDARY
Categories
(Core :: DOM: Streams, task)
Core
DOM: Streams
Tracking
()
RESOLVED
FIXED
116 Branch
People
(Reporter: saschanaz, Assigned: saschanaz)
Details
Attachments
(1 file)
|
48 bytes,
text/x-phabricator-request
|
diannaS
:
approval-mozilla-esr115+
|
Details | Review |
It can't run any JS because UnderlyingSourceAlgorithmsWrapper has no start algorithm at all.
|
Assignee | |
Comment 1•2 years ago
|
||
The "native" variants are not expected to run any script-runnable algorithms during the setup phase.
|
||
Updated•2 years ago
|
Attachment #9334659 -
Attachment description: WIP: Bug 1819124 - Mark "native" stream constructors as MOZ_CAN_RUN_SCRIPT_BOUNDARY → Bug 1819124 - Mark "native" stream constructors as MOZ_CAN_RUN_SCRIPT_BOUNDARY r=smaug
Pushed by krosylight@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/32326c8017e4
Mark "native" stream constructors as MOZ_CAN_RUN_SCRIPT_BOUNDARY r=smaug
|
||
Comment 3•2 years ago
|
||
| bugherder | ||
Status: NEW → RESOLVED
Closed: 2 years ago
status-firefox116:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → 116 Branch
|
|
Assignee | |
Comment 4•2 years ago
|
||
Comment on attachment 9334659 [details]
Bug 1819124 - Mark "native" stream constructors as MOZ_CAN_RUN_SCRIPT_BOUNDARY r=smaug
ESR Uplift Approval Request
- If this is not a sec:{high,crit} bug, please state case for ESR consideration: See https://bugzilla.mozilla.org/show_bug.cgi?id=1811882#c17, this is to make the build pass with it
- User impact if declined: See https://bugzilla.mozilla.org/show_bug.cgi?id=1811882#c14
- Fix Landed on Version: 116
- Risk to taking this patch: Low
- Why is the change risky/not risky? (and alternatives if risky): It just removes some static attributes and no more.
Attachment #9334659 -
Flags: approval-mozilla-esr115?
|
||
Comment 5•2 years ago
|
||
Comment on attachment 9334659 [details]
Bug 1819124 - Mark "native" stream constructors as MOZ_CAN_RUN_SCRIPT_BOUNDARY r=smaug
Approved for 1115.1esr
Attachment #9334659 -
Flags: approval-mozilla-esr115? → approval-mozilla-esr115+
|
|
||
Updated•2 years ago
|
status-firefox-esr115:
--- → fixed
You need to log in
before you can comment on or make changes to this bug.
Description
•