1811882 - Merge BodyStream and InputToReadableStreamAlgorithms

Status: RESOLVED FIXED

(Core :: DOM: Streams, enhancement)

Description

[Randell Jesup [:jesup] (needinfo me)]

This is more generic than Bodys (i.e. wider utility than in Fetch alone). I'm going to be using it in WebTransport, for example.

Name can be bikeshedded over...

This will be followed by adding a OutgoingByteStream

Comment 1

[Kagami Rosylight [:saschanaz] (they/them)]

Should we move the files to dom/streams?

Comment 2

[Randell Jesup [:jesup] (needinfo me)]

Attachment: Bug 1811882: change the name BodyStream to InputToReadableStream r=saschanaz,mgaudet

Comment 3

[Kagami Rosylight [:saschanaz] (they/them)]

We now have InputToReadableStreamAlgorithms added by bug 1815997.

Comment 4

[Kagami Rosylight [:saschanaz] (they/them)]

Attachment: WIP: Bug 1811882 - Part 1: Initialize InputToReadableStreamAlgorithms::mStream in StartCallback

So that it can be created without having ReadableStream first. (ReadableStream::Create also requires an algorithm, creating a mutual dependency.)

Depends on D178356

Comment 5

[Kagami Rosylight [:saschanaz] (they/them)]

Attachment: Bug 1811882 - Part 1: Implement NonAsyncInputToReadableStreamAlgorithms r=smaug

Wraps an nsIInputStream if it's not async, for blobs for example.

Depends on D178357

Comment 6

[Kagami Rosylight [:saschanaz] (they/them)]

Attachment: Bug 1811882 - Part 2: Implement ReadableStream::MaybeGetInputStreamIfUnread r=smaug

All existing GetBodyStreamHolder call is consciously done on unread streams, either to simply detect nsIInputStream-based streams or to get the internal nsIInputStream. The function can directly return nsIInputStream to fulfill the existing purposes.

Depends on D178358

Comment 7

[Kagami Rosylight [:saschanaz] (they/them)]

Attachment: Bug 1811882 - Part 5: Remove BodyStream in favor of InputToReadableStreamAlgorithms r=smaug

Depends on D178359

Comment 8

[Kagami Rosylight [:saschanaz] (they/them)]

Attachment: Bug 1811882 - Part 3: Use NonAsyncInputToReadableStreamAlgorithms for Blob::Stream() r=smaug

Depends on D178359

Comment 9

[Kagami Rosylight [:saschanaz] (they/them)]

Attachment: Bug 1811882 - Part 4: Use NonAsyncInputToReadableStreamAlgorithms for FetchBody::GetBody() r=smaug

Depends on D179074

Comment 10

[Kagami Rosylight [:saschanaz] (they/them)]

Attachment: Bug 1811882 - Part 1: Initialize InputToReadableStreamAlgorithms::mStream in StartCallback r=smaug

So that it can be created without having ReadableStream first. (ReadableStream::Create also requires an algorithm, creating a mutual dependency.)

Depends on D178356

Comment 11

[Kagami Rosylight [:saschanaz] (they/them)]

Attachment: Bug 1811882 - Part 3: Add InputToReadableStreamAlgorithms::TryCreateFromBaseInputStream r=smaug

Depends on D178359

Comment 12

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/dbeb3860cd2b
Part 1: Implement NonAsyncInputToReadableStreamAlgorithms r=smaug
https://hg.mozilla.org/integration/autoland/rev/745388791f89
Part 2: Implement ReadableStream::MaybeGetInputStreamIfUnread r=smaug
https://hg.mozilla.org/integration/autoland/rev/fb42e76c846c
Part 3: Use NonAsyncInputToReadableStreamAlgorithms for Blob::Stream() r=smaug
https://hg.mozilla.org/integration/autoland/rev/19391f5cd47e
Part 4: Use NonAsyncInputToReadableStreamAlgorithms for FetchBody::GetBody() r=smaug
https://hg.mozilla.org/integration/autoland/rev/8dc3bd71e12a
Part 5: Remove BodyStream in favor of InputToReadableStreamAlgorithms r=smaug

Comment 13

[Norisz Fay [:noriszfay]]

https://hg.mozilla.org/mozilla-central/rev/dbeb3860cd2b
https://hg.mozilla.org/mozilla-central/rev/745388791f89
https://hg.mozilla.org/mozilla-central/rev/fb42e76c846c
https://hg.mozilla.org/mozilla-central/rev/19391f5cd47e
https://hg.mozilla.org/mozilla-central/rev/8dc3bd71e12a

Comment 14

[Kagami Rosylight [:saschanaz] (they/them)]

Comment on attachment 9335881 [details]
Bug 1811882 - Part 4: Use NonAsyncInputToReadableStreamAlgorithms for FetchBody::GetBody() r=smaug

ESR Uplift Approval Request

• If this is not a sec:{high,crit} bug, please state case for ESR consideration: We see some weird behavior that this bug may have fixed.
• User impact if declined: Not clear, for now this is a speculative request.
• Fix Landed on Version: 116
• Risk to taking this patch: Low
• Why is the change risky/not risky? (and alternatives if risky): It's been quite stable in beta and requires no manual change to land in ESR.

Comment 15

[Dianna Smith [:diannaS]]

Comment on attachment 9334661 [details]
Bug 1811882 - Part 1: Implement NonAsyncInputToReadableStreamAlgorithms r=smaug

Approved for 115.1esr

Comment 16

[Pulsebot]

https://hg.mozilla.org/releases/mozilla-esr115/rev/b1f71c39a66b
https://hg.mozilla.org/releases/mozilla-esr115/rev/1b1d9b00302e
https://hg.mozilla.org/releases/mozilla-esr115/rev/c32497e98b2f
https://hg.mozilla.org/releases/mozilla-esr115/rev/9a92dae8f0ba
https://hg.mozilla.org/releases/mozilla-esr115/rev/264aee482837

Comment 17

[Cristian Tuns]

Backed out for causing build bustages in Fetch.cpp

• Backout link
• Push with failures
• Failure Log
• Failure line: /builds/worker/checkouts/gecko/dom/fetch/Fetch.cpp:1479:28: error: arguments must all be strong refs or caller's parameters when calling a function marked as MOZ_CAN_RUN_SCRIPT (including the implicit object argument). 'DerivedClass()->GetParentObject()' is neither.

Comment 18

[Kagami Rosylight [:saschanaz] (they/them)]

Nominated bug 1819124 for this.

Comment 19

[Pulsebot]

https://hg.mozilla.org/releases/mozilla-esr115/rev/196f38bbae68
https://hg.mozilla.org/releases/mozilla-esr115/rev/450dd73bab18
https://hg.mozilla.org/releases/mozilla-esr115/rev/b35c07d7f0f0
https://hg.mozilla.org/releases/mozilla-esr115/rev/675f09c574dd
https://hg.mozilla.org/releases/mozilla-esr115/rev/ff95b31e07df