1819163 - Crash in [@ java.lang.IllegalStateException: at androidx.fragment.app.FragmentManager.enqueueAction(FragmentManager.java)]

Status: NEW

(Firefox for Android :: General, defect, P3)

Description

[Chris Peterson [:cpeterson]]

Is this a bug in our code? Are we triggering this action after onSaveInstanceState? We have crash reports from both Fenix and Focus.

Crash report: https://crash-stats.mozilla.org/report/index/291856c6-117d-4b46-a76f-afe120230227

Java stack trace:

java.lang.IllegalStateException: Can not perform this action after onSaveInstanceState
	at androidx.fragment.app.FragmentManager.enqueueAction(FragmentManager.java:38)
	at androidx.fragment.app.BackStackRecord.commitInternal(BackStackRecord.java:56)
	at androidx.fragment.app.BackStackRecord.commit(BackStackRecord.java:2)
	at androidx.fragment.app.DialogFragment.dismissInternal(DialogFragment.java:110)
	at mozilla.components.feature.contextmenu.ContextMenuAdapter$$ExternalSyntheticLambda0.onClick(R8$$SyntheticClass:156)
	at android.view.View.performClick(View.java:6311)
	at android.view.View$PerformClick.run(View.java:24823)
	at android.os.Handler.handleCallback(Handler.java:790)
	at android.os.Handler.dispatchMessage(Handler.java:99)
	at android.os.Looper.loop(Looper.java:164)
	at android.app.ActivityThread.main(ActivityThread.java:6715)
	at java.lang.reflect.Method.invoke(Native Method)
	at com.android.internal.os.RuntimeInit$MethodAndArgsCaller.run(RuntimeInit.java:449)
	at com.android.internal.os.ZygoteInit.main(ZygoteInit.java:807)

Comment 1

[BugBot [:suhaib / :marco/ :calixte]]

The bug is linked to a topcrash signature, which matches the following criterion:

• Top 10 AArch64 and ARM crashes on nightly

:jonalmeida, could you consider increasing the severity of this top-crash bug?

For more information, please visit BugBot documentation.

Comment 2

[Jonathan Almeida [:jonalmeida]]

The crash upticks in 121 were addressed in bug 1864549.

Comment 3

[Chris Peterson [:cpeterson]]

(In reply to Jonathan Almeida [:jonalmeida] from comment #2)

The crash upticks in 121 were addressed in bug 1864549.

Jonathan, is this a general crash signature and bug 1864549 was just one instance (and thus we should keep this generic bug open)? Should we uplift the fix for bug 1864549 to a 120 dot release?

Comment 4

[Jonathan Almeida [:jonalmeida]]

I think that would be a good idea.

EDIT: We shouldn't because the fix is for a patch that was only introduced in 121, so we should let it ride the trains.

Comment 5

[BugBot [:suhaib / :marco/ :calixte]]

Based on the topcrash criteria, the crash signature linked to this bug is not a topcrash signature anymore.

For more information, please visit BugBot documentation.