Closed
Bug 1864549
Opened 2 years ago
Closed 2 years ago
[Crash] IllegalStateException in full screen notification dialog
Categories
(Firefox for Android :: General, defect, P3)
Tracking
()
RESOLVED
FIXED
121 Branch
| Tracking | Status | |
|---|---|---|
| firefox120 | --- | unaffected |
| firefox121 | --- | fixed |
People
(Reporter: matt-tighe, Assigned: towhite)
References
(Blocks 1 open bug)
Details
(Whiteboard: [fxdroid])
Crash Data
Attachments
(3 files)
Updated•2 years ago
|
Comment 1•2 years ago
|
||
Test webpage to trigger fullscreen and display a pop up dialog
Example set up:
- Host locally using:
python3 -m http.server 8080 - To access localhost from Android device run:
adb reverse tcp:8080 tcp:8080 - On Android device go to:
localhost:8080
Comment 3•2 years ago
|
||
Authored by https://github.com/t-p-white
https://github.com/mozilla-mobile/firefox-android/commit/9dd83d30b47f9d4ac465bb0eaade236837321ec3
[main] Bug 1864549 - Fix for IllegalStateException in full screen notification dialog
Status: NEW → RESOLVED
Closed: 2 years ago
status-firefox121:
--- → fixed
Flags: qe-verify+
Resolution: --- → FIXED
Target Milestone: --- → 121 Branch
Comment 4•1 year ago
|
||
Tom, should we uplift this fix to a 120 dot release? How risky is the fix compared to the crash volume?
Comment 5•1 year ago
|
||
Answering for twhite while they are on PTO. I think this is a good idea and I'll create the uplift request.
Flags: needinfo?(towhite)
Updated•1 year ago
|
Crash Signature: [@ java.lang.IllegalStateException: Can not perform this action after onSaveInstanceState
at androidx.fragment.app.FragmentManager.enqueueAction(FragmentManager.java:38)
at androidx.fragment.app.BackStackRecord.commitInternal(BackStackRecord.jav…
| Comment hidden (obsolete) |
| Comment hidden (obsolete) |
Updated•1 year ago
|
Flags: qe-verify+
Comment 8•1 year ago
|
||
Comment on attachment 9363486 [details] [review]
[mozilla-mobile/firefox-android] Bug 1864549 - Fix for IllegalStateException in full screen notification dialog (#4471)
Clearing uplift request. I realized that this fix is for `FullScreenNotificationDialog` which only landed in 121, so uplifting this to 120 doesn't make sense.
Sorry for comment churn!
Attachment #9363486 -
Flags: approval-mozilla-release?
Updated•1 year ago
|
You need to log in
before you can comment on or make changes to this bug.
Description
•