1819254 - When trying to change quality or speed of full screen YouTube video, video exits full screen and landscape changes to portrait

Status: RESOLVED FIXED

(GeckoView :: Media, defect, P1)

Description

[user3987]

User Agent: Mozilla/5.0 (Android 13; Mobile; rv:109.0) Gecko/111.0 Firefox/111.0

Steps to reproduce:

Open any YouTube video. Watch it on full screen. While watching, you want to change quality or speed of the video so you click on settings icon on the top right corner. Now when you click on "quality" or "speed" option, the full screen mode disappears, i.e. landscape mode changes to portrait and you need to manually re-enter to full screen mode. You've to do it every time when you want to change those settings again.
(As a short note, I'm on firefox beta v 111.0b6)

Actual results:

When watching YouTube on fullscreen mode and clicking on "quality" or "speed" option from settings, the full screen mode disappears, i.e. landscape mode changes to portrait and you need to manually re-enter to full screen mode.

Expected results:

Quality or speed should have changed without exiting the full screen.

Comment 1

[Chris Peterson [:cpeterson]]

I can reproduce in Firefox and Focus Beta 111 and Nightly 112, but not Release 110 or Chrome. On my device, the video exits full screen mode, but the page orientation doesn't switch from landscape back to portrait.

Comment 2

[Chris Peterson [:cpeterson]]

user3987 originally reported this bug on Reddit: https://www.reddit.com/r/firefox/comments/11d7kys/youtube_problem_on_firefox_beta/

Comment 3

[Chris Peterson [:cpeterson]]

Could this be a regression from bug 1813416?

Comment 4

[Chris Peterson [:cpeterson]]

Makoto, Kevin suspects this bug is a regression from bug 1767449. YouTube now exits full screen in Firefox but not Chrome. Is this a bug in our code or do we need to ask YouTube to change how they handle screen orientation lock on Firefox?

Comment 5

[Makoto Kato [:m_kato]]

This is correct behavior when screen orientation lock is unlocked by existing full screen. But this problem is that full screen is exited when something prompt is shown then actived.

Also, screen orientation lock is disabled by beta and release. So this is disabled by 111. But this occurs on 111 beta, so we need right regression range. (Firefox 109 doesn't exit fullscreen)

Comment 6

[Chris Peterson [:cpeterson]]

QA, can you please test whether this bug is reproducible in the GeckoViewExample app? If it is, can you try using mozregression to bisect which Nightly build first introduced this bug?

This bug might have landed in Nightly 111 or it might have landed in Nightly 112 and was then uplifted to Beta 111. So you should try bisecting builds between Nightly 110 (a known good version) and the latest Nightly build.

Comment 7

[Makoto Kato [:m_kato]]

I guess that https://github.com/mozilla-mobile/firefox-android/pull/789

Comment 8

[Makoto Kato [:m_kato]]

QA, can you please test whether this bug is reproducible in the GeckoViewExample app

I cannot reproduce this on GVE.

Comment 9

[Makoto Kato [:m_kato]]

When I backed out https://github.com/mozilla-mobile/firefox-android/pull/789, this doesn't occur. Petru, could you look this?

Comment 10

[Petru-Mugurel Lingurar [:petru]]

Agree that this is the result of https://github.com/mozilla-mobile/firefox-android/pull/789.
We'll need to investigate more on how to keep both functionalities working.

Comment 11

[Donal Meehan [:dmeehan]]

:cpeterson :petru this is the final week of 111 beta, next week is RC week.
As mentioned above this was backported to the releases_v111 branch.
In terms of timing/impact could you consider backing out the PR you backported?

Comment 12

[Chris Peterson [:cpeterson]]

(In reply to Donal Meehan [:dmeehan] from comment #11)

:cpeterson :petru this is the final week of 111 beta, next week is RC week.
As mentioned above this was backported to the releases_v111 branch.
In terms of timing/impact could you consider backing out the PR you backported?

Petru recommends that we not back out that fix this late in the release cycle. He will investigate other approaches for fixing YouTube, so I will reassign this bug to him.

I'm clearing the qe-verify flag: Makoto found the regression, so we don't need QA to test.

Comment 13

[Chris Peterson [:cpeterson]]

Setting firefox111 back to "affected" in case we have an alternate fix we can uplift to a 111 dot release.

Comment 14

[Petru-Mugurel Lingurar [:petru]]

I think the difference here is whether the user initiated the prompt.
Arturo helped with some prompts which can be triggered programatically - Alert,TextPrompt, TimeSelection,
But we're curious if there are more.
We currently support this prompts in AC

• https://github.com/mozilla-mobile/firefox-android/blob/5b3392797a1d5042f6e3c4b1aa019daef7e2cacf/android-components/components/feature/prompts/src/main/java/mozilla/components/feature/prompts/PromptFeature.kt#L469-L488 and
• https://github.com/mozilla-mobile/firefox-android/blob/5b3392797a1d5042f6e3c4b1aa019daef7e2cacf/android-components/components/feature/prompts/src/main/java/mozilla/components/feature/prompts/PromptFeature.kt#L640-L869

@Emilio sorry for pinging you but maybe you can help with the full list of prompts which can be triggered by the website vs prompts which can be triggered only by the user?

Comment 15

[Emilio Cobos Álvarez (:emilio)]

Confirm, File, Color for sure can be triggered programmatically assuming it just comes from window.confirm(), <input type=file> and <input type=color>.

SingleChoice, MenuChoice, MultipleChoice I'm not convinced they can, but they probably should.

I'm confused tho, why do we want to exit fullscreen on any of those, independently of they being user or programmatically triggered?

Comment 16

[BMO Automation]

Attachment: [mozilla-mobile/firefox-android] Bug 1819254 - Don't exit fullscreen for user input prompts (#1133)

Comment 17

[Donal Meehan [:dmeehan]]

Resolving and setting 112 to fixed, since the PR merged into main.
This will need a release uplift request for inclusion in a 111 dot release.

Comment 18

[BMO Automation]

Attachment: [mozilla-mobile/firefox-android] Bug 1819254 - Don't exit fullscreen for user input prompts (backport #1133) (#1151)

Comment 19

[Petru-Mugurel Lingurar [:petru]]

Comment on attachment 9321632 [details] [review]
[mozilla-mobile/firefox-android] Bug 1819254 - Don't exit fullscreen for user input prompts (backport #1133) (#1151)

Beta/Release Uplift Approval Request

• User impact if declined: All prompts shown while being in fullscreen will exit fullscreen. This patch limits such scenarios.
• Is this code covered by automated tests?: Yes
• Has the fix been verified in Nightly?: No
• Needs manual test from QE?: Yes
• If yes, steps to reproduce: Open any YouTube video. Watch it on full screen. While watching, you want to change quality or speed of the video so you click on settings icon on the top right corner. Now when you click on "quality" or "speed" option, the full screen mode disappears, i.e. landscape mode changes to portrait and you need to manually re-enter to full screen mode. You've got to do it every time when you want to change those settings again.
• List of other uplifts needed: None
• Risk to taking this patch: Low
• Why is the change risky/not risky? (and alternatives if risky): Small change, soon to be verified by QA.
• String changes made/needed:
• Is Android affected?: Yes

Comment 20

[Lorand Janos]

Verified as fixed on the latest Nightly 112.0a1 (2023-03-08) build.
When setting both speed and/or quality with a video played in full screen, the video remains in full screen after the setting is done.
Device used: Google Pixel 7 (Android 13).
Marking the ticket as verified fixed for 112.

Comment 21

[Chris Peterson [:cpeterson]]

This bug was a regression in 111, but I don't think it's critical enough to uplift to a 111 dot release. We have more critical fixes already planned for 111.0.1. We can reconsider for 111.0.2 after the fix has baked on Beta 112 for a week.

Comment 22

[Chris Peterson [:cpeterson]]

I don't think we need to uplift this fix to the next 111 dot release. This fix can ride the trains in 112.

Comment 23

[Donal Meehan [:dmeehan]]

:cpeterson if you and the team think a request is too risky, when setting the version to wontfix please also clear the uplift request.

Comment 24

[Donal Meehan [:dmeehan]]

Comment on attachment 9321632 [details] [review]
[mozilla-mobile/firefox-android] Bug 1819254 - Don't exit fullscreen for user input prompts (backport #1133) (#1151)

See comment 22