1767449 - Turn on dom.screenorientation.allow-lock=true in GeckoView Nightly

Status: RESOLVED FIXED

(GeckoView :: General, enhancement, P2)

Description

[Makoto Kato [:m_kato]]

Fenix has implemented orientation delegate via https://github.com/mozilla-mobile/fenix/issues/23415. We should enable this pref in Nightly at least.

Comment 1

[Chris Peterson [:cpeterson]]

Makoto, are there known bugs we need to fix before this feature is ready to ride the trains to Beta and Release?

Comment 2

[Makoto Kato [:m_kato]]

I think most issues were done for nightly.

I think we need to fix bug 1750670 and bug 1763052 (this causes WPT failures) at least if we turn on this pref in all channels.
And I guess bug 1744288 is optional, it may occur on youtube.com (YouTube had some issues for orientation lock when I tested it one month ago), So I have to verify it again.

Comment 3

[Chris Peterson [:cpeterson]]

Assigning this bug to Makoto. He will decide whether we need to prioritize it for 2022 H2.

Comment 4

[Chris Peterson [:cpeterson]]

Enhancements should have severity N/A.

Comment 5

[Makoto Kato [:m_kato]]

Attachment: Bug 1767449 - Turn on screen.orientation.lock in Nightly. r=smaug

I would like to enable this API in Nightly for testing.

Supported in GeckoView and Windows tablet mode. Other platforms are no
affect by this preference. WPT [*1] runs on non-supported platform, so
a lot of tests are failure. (GeckoView passes a lot of tests [*2].)

Also, there is an issue of hidden document [*2], it isn't fixed by spec
side yet.

*1 https://wpt.fyi/results/screen-orientation
*2 https://searchfox.org/mozilla-central/source/testing/web-platform/meta/screen-orientation
*3 https://github.com/w3c/screen-orientation/pull/232

Comment 6

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/7b15c072a2d8
Turn on screen.orientation.lock in Nightly. r=smaug

Comment 7

[Noemi Erli[:noemi_erli]]

https://hg.mozilla.org/mozilla-central/rev/7b15c072a2d8

Comment 8

[Kevin Brosnan [Ex-Mozilla]]

Release Note Request (optional, but appreciated)
[Why is this notable]: New web developer functionality
[Affects Firefox for Android]: only
[Suggested wording]: all ready added to the 111 relnote doc
[Links (documentation, blog post, etc)]:

https://developer.mozilla.org/en-US/docs/Web/API/ScreenOrientation/lock needs updating to show support.

Comment 9

[Makoto Kato [:m_kato]]

(In reply to Kevin Brosnan [:kbrosnan] from comment #8)

Release Note Request (optional, but appreciated)
[Why is this notable]: New web developer functionality
[Affects Firefox for Android]: only
[Suggested wording]: all ready added to the 111 relnote doc
[Links (documentation, blog post, etc)]:

https://developer.mozilla.org/en-US/docs/Web/API/ScreenOrientation/lock needs updating to show support.

This is only Nightly, so I don't turn on this on release channel yet.