1819898 - Use internal content policy types for determining IsUpgradableDisplayType

Status: RESOLVED FIXED

(Core :: DOM: Security, task, P3)

Description

[Frederik Braun [:freddy]]

Looks like we use the external contentpolicytype and the internal contentpolicytype interchangeably.

For a more robust implementation, more consistency would be reasonable.
The "is upgradable display type" check looks at the external IMAGE and MEDIA types (https://searchfox.org/mozilla-central/rev/f7edb0b474a1a922f3285107620e802c6e19914d/dom/base/nsContentUtils.cpp#8647-8651), but that also includes <track>?

Our telemetry seems to have looked at the internal content policy type which is more detailed

Further breadcrumbs:
https://searchfox.org/mozilla-central/rev/f7edb0b474a1a922f3285107620e802c6e19914d/dom/security/nsMixedContentBlocker.cpp#757-763

Comment 1

[Christoph Kerschbaumer [:ckerschb]]

Attachment: Bug 1819898: Use internal content policy types for determining IsUpgradableDisplayType, r=freddyb

Comment 2

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/5804b3277416
Use internal content policy types for determining IsUpgradableDisplayType, r=freddyb

Comment 3

[Atila Butkovits]

https://hg.mozilla.org/mozilla-central/rev/5804b3277416