Open Bug 1820474 Opened 1 year ago Updated 6 months ago

Write test that mixed-content-auto-upgrading does not apply to `<track>` elements

Categories

(Core :: DOM: Security, task, P3)

task

Tracking

()

People

(Reporter: ckerschb, Unassigned, Mentored)

References

Details

(Keywords: good-first-bug, Whiteboard: [domsecurity-backlog])

Attachments

(1 obsolete file)

Internally we match track to type media, though the spec for mixed content auto upgrading explicitly stated that we should only upgrade:

  • image,
  • audio
  • video.

We should write an automated test to ensure track is not subject to mixed-content-auto-upgrading.

Depends on: 1819898
Blocks: 1672106
Mentor: fbraun
Severity: -- → S3
Type: defect → task
Keywords: good-first-bug
Priority: -- → P3
Summary: Write test and ensure mixed-content-auto-upgrading does not apply to track → Write test and ensure mixed-content-auto-upgrading does not apply to `<track>` elements
Whiteboard: [domsecurity-backlog]

Sir, I want to give a try to this bug,

Great. If you want to tackle this bug, please follow the guide at https://wiki.mozilla.org/Good_first_bug to get a working build environment and make sure you can run the test file dom/security/test/mixedcontentblocker/test_main.html#35 using ./mach test <path to test>.

The first steps is to make a change to the test that adds a case for a <track> element.

Feel free to reach out to me as @fbraun:mozilla.org on Matrix (Instructions at https://wiki.mozilla.org/Matrix) for further questions.

Ok, Thanks, I will give my best

Sir, I am trying to submit a patch but getting the error Freddy is not a valid reviewer name, and I also looked for the same on Mozilla but not able to find you. Please have a look at this - https://paste.mozilla.org/tG8prCS1

That's odd. You can go without a reviewer name (though maybe "freddyb" could work).

Assignee: nobody → tiwari.abhishektiwari23
Status: NEW → ASSIGNED
Attachment #9327579 - Attachment is obsolete: true

To clarify, we do not upgrade <track> since https://bugzilla.mozilla.org/show_bug.cgi?id=1819898. This is just about the missing test case. I think the bug mentioned above can be closed?

Summary: Write test and ensure mixed-content-auto-upgrading does not apply to `<track>` elements → Write test that mixed-content-auto-upgrading does not apply to `<track>` elements

This good-first-bug hasn't had any activity for 2 months, it is automatically unassigned.
For more information, please visit BugBot documentation.

Assignee: tiwari.abhishektiwari23 → nobody
Status: ASSIGNED → NEW
You need to log in before you can comment on or make changes to this bug.