1819965 - "TabSession.executeInChild" will hang if message manager has been replaced

Status: RESOLVED FIXED

(Remote Protocol :: CDP, defect, P1)

Description

[Henrik Skupin [:whimboo][⌚️UTC+2]]

Currently we load our framescript for the content browser only once when initially creating the TabSession for a tab. But that means if the browsing context gets replaced due to a navigation the message manager is replaced as well and the new one doesn't load the framescript. As such calling executeInChild will finally end up using a dead message manager.

Fixing that gets us a bit closer to a fix for bug 1600054, but we still suffer from data loss given that all the data that we store happens inside the content process. So side-effects are expected but at least we do no longer hang.

Comment 1

[Henrik Skupin [:whimboo][⌚️UTC+2]]

Attachment: Bug 1819965 - [cdp] Re-load framescript when browsing context gets replaced due to a navigation.

Comment 2

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/e565bfdc6250
[cdp] Re-load framescript when browsing context gets replaced due to a navigation. r=webdriver-reviewers,jdescottes

Comment 3

[Noemi Erli[:noemi_erli]]

https://hg.mozilla.org/mozilla-central/rev/e565bfdc6250