Closed Bug 1820487 Opened 1 year ago Closed 1 year ago

RemoteAgent fails to stop the httpd.js listener if CDP and/or BiDi fail to stop

Categories

(Remote Protocol :: CDP, defect, P1)

defect
Points:
1

Tracking

(firefox112 fixed)

RESOLVED FIXED
112 Branch
Tracking Status
firefox112 --- fixed

People

(Reporter: whimboo, Assigned: whimboo)

References

Details

(Whiteboard: [webdriver:m6])

Attachments

(1 file)

If CDP or WebDriver BiDi fail to stop and as result raise an exception the Remote Agent does not stop the httpd.js listener:

https://searchfox.org/mozilla-central/rev/00ea1649b59d5f427979e2d6ba42be96f62d6e82/remote/components/RemoteAgent.sys.mjs#311-315

We should probably fetch the exception within the stop() method for both the CDP and WebDriver BiDi protocol and log some details there, but not let it propagate up to the Remote Agent. Especially if we fail to stop the listener the port will still be taken and will cause side-effects.

Assignee: nobody → hskupin
Status: NEW → ASSIGNED
Points: --- → 1
Priority: -- → P1
Whiteboard: [webdriver:m6]
Pushed by hskupin@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/3a86270a109c
[remote] RemoteAgent fails to stop the httpd.js listener if CDP and/or BiDi fail to stop. r=webdriver-reviewers,jdescottes
Status: ASSIGNED → RESOLVED
Closed: 1 year ago
Resolution: --- → FIXED
Target Milestone: --- → 112 Branch
You need to log in before you can comment on or make changes to this bug.