1820057 - Most menu items/message actions fail after global search `Show results as list` - delete, forward, reply, `open message in containing folder`, etc

Status: RESOLVED FIXED

(Thunderbird :: Search, defect, P1)

Description

[Wayne Mery (:wsmwk)]

Now that Bug #1817374 is fixed

1. do global search
2. Show results as list
3. click on a message
4. do open message in containing folder

Error console has
Uncaught
Exception { name: "NS_ERROR_FAILURE", message: "Component returned failure code: 0x80004005 (NS_ERROR_FAILURE) [nsIMessenger.msgHdrFromURI]", result: 2147500037, filename: "chrome://messenger/content/mailContext.js", lineNumber: 252, columnNumber: 0, data: null, stack: "fillMailContextMenu@chrome://messenger/content/mailContext.js:252:23\ninit/<@chrome://messenger/content/mailContext.js:113:14\nconnectedCallback/<@chrome://messenger/content/about3Pane.js:3117:15\n", location: XPCWrappedNative_NoHelper }

Comment 1

[Wayne Mery (:wsmwk)]

The user can display messages in the message list, but at least half the actions one can take on a message are broken.
I made it blocking message list meta bug, but if there is a better choice feel free to change it.

Comment 2

[Alessandro Castellani [:aleca]]

Attachment: Bug 1820057 - Fix context message actions in synthetic view results list. r=aleca

Comment 3

[Geoff Lankow (:darktrojan)]

While here I think we should extend browser_mailContext.js to cover this case.

Comment 4

[Wayne Mery (:wsmwk)]

This will also solve "Search Messages" actions being disabled?

Comment 5

[Alessandro Castellani [:aleca]]

It should.
I'm going through all menu items (which are a lot) and making sure we're at parity with 102.
Hopefully I'll finish this Friday or early next week

Comment 6

[Wayne Mery (:wsmwk)]

Also, Location column is never populated. Let me know if you want a separate bug report for that.

Comment 7

[Alessandro Castellani [:aleca]]

(In reply to Wayne Mery (:wsmwk) from comment #6)

Also, Location column is never populated. Let me know if you want a separate bug report for that.

Mhhh, that data comes from c++, so it might be a separate issue

Comment 8

[Geoff Lankow (:darktrojan)]

Attachment: Bug 1820057 - Extend mail context menu test to cover more locations. r=aleca

Depends on D171657

Comment 9

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/comm-central/rev/36a6db9ee0b3
Fix context message actions in synthetic view results list. r=aleca
https://hg.mozilla.org/comm-central/rev/f63546ad978f
Extend mail context menu test to cover more locations. r=aleca

Comment 10

[Wayne Mery (:wsmwk)]

Comment on attachment 9323417 [details]
Bug 1820057 - Extend mail context menu test to cover more locations. r=aleca

[Triage Comment]
Approved for beta

Comment 11

[Wayne Mery (:wsmwk)]

Comment on attachment 9321240 [details]
Bug 1820057 - Fix context message actions in synthetic view results list. r=aleca

[Triage Comment]
Approved for beta

Comment 12

[Rob Lemley [:rjl]]

Thunderbird 112.0b3:
https://hg.mozilla.org/releases/comm-beta/rev/fcfd28831967
https://hg.mozilla.org/releases/comm-beta/rev/81423376acc1