1820141 - The PiP's subtitle panel is not properly read by the Screen Readers (NVDA/ORCA/VoiceOver)

Status: VERIFIED FIXED

(Toolkit :: Picture-in-Picture, defect, P3)

Description

[Daniel Bodea [:danibodea]]

Note

• When the user uses Screen Readers to navigate through the PiP's subtitle settings paned and he focuses the subtitle toggle, he will notice that the functionality of the toggle is not announced in any way.

Found in

• Nightly v102.0a1

Affected versions

• Nightly v102.0a1

Tested platforms

• Affected platforms: Windows 10, MacOS 11, Ubuntu 22
• Unaffected platforms: -

Steps to reproduce

1. Launch the screen reader (NVDA/VoiceOverORCA)
2. Load a YT video with subtitles
3. Play the video and launch the PiP.
4. Focus the Subtitle button and press SPACEBAR.

Expected result

• The Panel opening should be announced.

Actual result

• Nothing is announced.

5. Press TAB to focus the subtitles toggle

Expected result

• The toggle's functionality should properly be announced.

Actual result

• The toggle's functionality is not properly announced.
  • Windows 10 + NVDA: "Checkbox checked"
  • MacOS + VoiceOver: "Checked checkbox"
    Ubuntu22 + ORCA: "Checkbox checked"

6. Press TAB to move focus to thSubtitle's Font Size radio buttons.

Expected result

• The radio button's functionality should properly be announced.

Actual result

• The toggle's functionality is not properly announced.
  • Windows 10 + NVDA: "Medium radio button checked 2/3"
  • MacOS + VoiceOver: "Entering Mediun group; medium selected radio button 2/3"
  • Ubuntu22 + ORCA: "Medium label; medium; selected radio button"

Regression range

• This is not a regression.

Additional notes

• I am unsure how relevant Screen Reader accessibility is for this panel; if S3 severity is incorrect, feel free to change it.

Comment 1

[BugBot [:suhaib / :marco/ :calixte]]

The severity field for this bug is set to S3. However, the accessibility severity is higher, [access-s2].
:mhowell, could you consider increasing the severity?

For more information, please visit auto_nag documentation.

Comment 2

[kpatenio]

We are keeping severity at S3 for now.

Comment 3

[kpatenio]

Attachment: Bug 1820141 - improve accessibility for PiP subtitles panel

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/56d8a4e57350
improve accessibility for PiP subtitles panel r=pip-reviewers,bnasar,fluent-reviewers,flod,mhowell

Comment 5

[Sandor Molnar[:smolnar]]

https://hg.mozilla.org/mozilla-central/rev/56d8a4e57350

Comment 6

[Daniel Bodea [:danibodea]]

After fix:

• Windows 10 + NVDA:
  • focusing the subs button: "Subtitles button, collapsed"
  • focusing the subs toggle: "Subtitle settings grooving; Subtitles checkbox checked"
  • focusing font size radios: "Font size grooving; Medium radio button checked, 2 of 3"
• Ubuntu 22 + ORCA:
  • focusing the subs button: "subtitles collapsed push-button"
  • focusing the subs toggle: "subtitles settings panel; subtitles checkbox checked, expanded"
  • focusing font size radios: "font size panel; Medium; selected radio button"
• MacOS 11 + VoiceOver:
  • focusing the subs button: "subtitles collapsed button. You are currently on a button..."
  • focusing the subs toggle: "subtitles checked check-box; You are currently on a check-box..."
  • focusing font size radios: "entering font size group; Medium, selected radio button"

Based on these results tested with Nightly v114.0a1, I confirm this fix.