1820169 - The "Add to shortcuts" and "Remove from shortcuts" snackbars are hidden behind the address bar

Status: VERIFIED FIXED

(Fenix :: Top Sites, defect, P1)

Description

[Lorand Janos]

Attachment: az_recorder_20230303_151556.mp4

Steps to reproduce

1. Go to a different website that the ones from top sites.
2. Go to 3 dot menu > Add to shortcuts and observe the snackbar.
3. Go to 3 dot menu > Remove from shortcuts and observe the snackbar.

Expected behavior

The snackbar is clearly visible

Actual behavior

The snackbar is hidden behind the Address bar.

Device information

• Firefox version: Nightly 112.0a1, Beta 111.0b8
• Android device model: Google Pixel 3A, Oppo Find X5, Google Pixel 7.
• Android OS version: 11, 13.

Any additional information?

Comment 1

[Petru-Mugurel Lingurar [:petru]]

Seems like a recent regression after https://bugzilla.mozilla.org/show_bug.cgi?id=1812518 which was uplifted in 111 so we should look into fixing this as soon as possible.

Comment 2

[BMO Automation]

Attachment: [mozilla-mobile/firefox-android] Bug 1820169 - Ensure shortcuts snackbars are shown (#1123)

Comment 3

[BMO Automation]

Attachment: [mozilla-mobile/firefox-android] Bug 1820169 - Ensure shortcuts snackbars are shown (backport #1123) (#1150)

Comment 4

[Petru-Mugurel Lingurar [:petru]]

Comment on attachment 9321626 [details] [review]
[mozilla-mobile/firefox-android] Bug 1820169 - Ensure shortcuts snackbars are shown (backport #1123) (#1150)

Beta/Release Uplift Approval Request

• User impact if declined: A recent regression was introduced in 111: two snackbars from when adding or removing a topsite from the browser menu would not be shown correctly.
• Is this code covered by automated tests?: No
• Has the fix been verified in Nightly?: No
• Needs manual test from QE?: Yes
• If yes, steps to reproduce: Go to a different website that the ones from top sites.
  Go to 3 dot menu > Add to shortcuts and observe the snackbar.
  Go to 3 dot menu > Remove from shortcuts and observe the snackbar.
• List of other uplifts needed: None
• Risk to taking this patch: Low
• Why is the change risky/not risky? (and alternatives if risky): Small change, soon to be verified by QA.
• String changes made/needed:
• Is Android affected?: Yes

Comment 5

[Lorand Janos]

Verified as fixed on the latest Nightly 112.0a1 (2023-03-08) build.
The snackbars are now visible.
Device used: Google Pixel 7 (Android 13).
Marking the ticket as verified for 112.

Comment 6

[Donal Meehan [:dmeehan]]

Comment on attachment 9321626 [details] [review]
[mozilla-mobile/firefox-android] Bug 1820169 - Ensure shortcuts snackbars are shown (backport #1123) (#1150)

Approved for Fenix 111.1.0

Comment 7

[BMO Github Automation]

Authored by https://github.com/Mugurell
https://github.com/mozilla-mobile/firefox-android/commit/218ac25a9c94df4f202fe4c6adb368d150a007d0
[releases_v111] Bug 1820169 - Ensure shortcuts snackbars are shown

Comment 8

[Lorand Janos]

Verified as fixed on the latest RC 111.1.0 build.
The snackbars are now visible.
Device used: Google Pixel 7 (Android 13).
Marking the ticket as verified for 111 as well.