1820200 - Permanent devtools/shared/commands/resource/tests/browser_resources_network_events.js | single tracking bug

Status: RESOLVED FIXED

(DevTools :: General, defect, P5)

Description

[Treeherder Bug Filer]

Filed by: archaeopteryx [at] coole-files.de
Parsed log: https://treeherder.mozilla.org/logviewer?job_id=407726580&repo=autoland
Full log: https://firefox-ci-tc.services.mozilla.com/api/queue/v1/task/ajgzGUw-Q_qrlS9BO2rb4g/runs/0/artifacts/public/logs/live_backing.log

---

This failure did not get logged since bug 1819134 caused a regression which got fixed in bug 1819445. The test will be disabled until the regressing change has been identified.

[task 2023-03-03T15:39:56.624Z] 15:39:56     INFO - TEST-PASS | devtools/shared/commands/resource/tests/browser_resources_network_events.js | The 'isNavigationRequest' attribute is correct - 
[task 2023-03-03T15:39:56.624Z] 15:39:56     INFO - Buffered messages finished
[task 2023-03-03T15:39:56.626Z] 15:39:56     INFO - TEST-UNEXPECTED-FAIL | devtools/shared/commands/resource/tests/browser_resources_network_events.js | The 'blockedReason' attribute is correct - Got "unknown", expected "NS_BINDING_ABORTED"
[task 2023-03-03T15:39:56.626Z] 15:39:56     INFO - Stack trace:
[task 2023-03-03T15:39:56.626Z] 15:39:56     INFO - chrome://mochikit/content/browser-test.js:test_is:1510
[task 2023-03-03T15:39:56.627Z] 15:39:56     INFO - chrome://mochitests/content/browser/devtools/shared/commands/resource/tests/browser_resources_network_events.js:assertResources:313
[task 2023-03-03T15:39:56.628Z] 15:39:56     INFO - chrome://mochitests/content/browser/devtools/shared/commands/resource/tests/browser_resources_network_events.js:onAvailable:241
[task 2023-03-03T15:39:56.628Z] 15:39:56     INFO - resource://devtools/shared/commands/resource/resource-command.js:_notifyWatchers:872
[task 2023-03-03T15:39:56.628Z] 15:39:56     INFO - resource://devtools/shared/throttle.js:later:33
[task 2023-03-03T15:39:56.629Z] 15:39:56     INFO - resource://gre/modules/Timer.sys.mjs:notify:49

Comment 1

[Sebastian Hengst [:aryx] (needinfo me if it's about an intermittent or backout)]

Attachment: Bug 1820200 - temporarily disable browser_resources_network_events.js until regressing change has been identified

The failure did get logged since bug 1819134 caused a regression which got fixed
in bug 1819445. The test will be reenabled once the regressing change has been
identified.

Comment 2

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/b045fa33205d
temporarily disable browser_resources_network_events.js until regressing change has been identified CLOSED TREE

Comment 3

[Julian Descottes [:jdescottes]]

We regressed this in https://bugzilla.mozilla.org/show_bug.cgi?id=1803546 and https://bugzilla.mozilla.org/show_bug.cgi?id=1819279.
Before those bugs we would always use ChromeUtils.getXPCOMErrorName to try to get a more accurate blocked reason, but now we only do it for NS_ERROR_UNKNOWN_HOST.

Comment 4

[Julian Descottes [:jdescottes]]

Attachment: Bug 1820200 - [devtools] Fix expected blocked reasons in browser_resources_network_events.js

Depends on D171577

Short summary of the history here: the assert which regressed was initially added in https://bugzilla.mozilla.org/show_bug.cgi?id=1745944
This is when we started using ChromeUtils.getXPCOMErrorName to get more accurate blockedReasons.

However after Bug https://bugzilla.mozilla.org/show_bug.cgi?id=1819279, we now only translate blockedReasons for NS_ERROR_UNKNOWN_HOST

Which leads all the other blocked reasons to show up as "unknown". Maybe this was the wrong call and we need to adjust the implementation, but this
patch at least makes the test consistent with the implementation so that we can re-enable it.

(the regression was not detected, because the harness was unexpectedly throwing in the middle of the test)

Comment 5

[Norisz Fay [:noriszfay]]

https://hg.mozilla.org/mozilla-central/rev/b045fa33205d

Comment 6

[:Gijs (he/him)]

Disabling != fixing :-)

Comment 7

[Intermittent Failures Robot]

6 failures in 3752 pushes (0.002 failures/push) were associated with this bug in the last 7 days.

Repository breakdown:

• autoland: 6

Platform and build breakdown:

• linux1804-64-qr: 1
  • debug: 1
• linux1804-64-shippable-qr: 2
  • opt: 2
• macosx1015-64-shippable-qr: 1
  • opt: 1
• windows10-64-2004-shippable-qr: 1
  • opt: 1
• windows11-64-2009-shippable-qr: 1
  • opt: 1

For more details, see:
https://treeherder.mozilla.org/intermittent-failures/bugdetails?bug=1820200&startday=2023-02-27&endday=2023-03-05&tree=all

Comment 8

[Hubert Boma Manilla (:bomsy)]

Attachment: Bug 1820200 - [devtools] Fix and enable browser_resources_network_events.js test r=#devtools-reviewers

Comment 9

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/e4c5c6db6524
[devtools] Fix and enable browser_resources_network_events.js test r=jdescottes,devtools-reviewers

Comment 10

[Noemi Erli[:noemi_erli]]

https://hg.mozilla.org/mozilla-central/rev/e4c5c6db6524

Comment 11

[BugBot [:suhaib / :marco/ :calixte]]

The patch landed in nightly and beta is affected.
:jdescottes, is this bug important enough to require an uplift?

• If yes, please nominate the patch for beta approval.
• If no, please set status-firefox112 to wontfix.

For more information, please visit auto_nag documentation.

Comment 12

[Julian Descottes [:jdescottes]]

Forwarding to Hubert.

Comment 13

[Hubert Boma Manilla (:bomsy)]

Comment on attachment 9323012 [details]
Bug 1820200 - [devtools] Fix and enable browser_resources_network_events.js test r=#devtools-reviewers

Beta/Release Uplift Approval Request

• User impact if declined: Users may see unusual error requests
• Is this code covered by automated tests?: Yes
• Has the fix been verified in Nightly?: Yes
• Needs manual test from QE?: No
• If yes, steps to reproduce:
• List of other uplifts needed: None
• Risk to taking this patch: Low
• Why is the change risky/not risky? (and alternatives if risky): Low risk, fixes block error statuses.
• String changes made/needed:
• Is Android affected?: Yes

Comment 14

[Dianna Smith [:diannaS]]

Comment on attachment 9323012 [details]
Bug 1820200 - [devtools] Fix and enable browser_resources_network_events.js test r=#devtools-reviewers

Approved for 112.0b6

Comment 15

[Dianna Smith [:diannaS]]

https://hg.mozilla.org/releases/mozilla-beta/rev/37197d61841e