1820209 - Replace "telemetryDataDeletionLearnMore" in about:preferences#privacy with moz-support-link

Status: RESOLVED FIXED

(Toolkit :: UI Widgets, task, P3)

Description

[Tim Giles [:tgiles]]

I replaced most of the "Learn more" labels in about:preferences, but it seems this one was hiding from me. There's some layout issue with this particular link, so if we can fix it as part of this patch then great, but I don't think it should be a blocker for landing a fix.

To help Mozilla out with this bug, here's the steps:

1. Comment here on the bug that you want to volunteer to help.
   This will tell others that you're working on the next steps.
2. Download and build the Firefox source code
   • If you have any problems, please ask on Element/Matrix in the #introduction channel. They're there to help you get started.
   • You can also read the Developer Guide, which has answers to most development questions.
3. Start working on this bug.
   • You can see this link by navigating to about:preferences#privacy and navigating to the "Nightly Data Collection and Use" heading and unchecking the "Allow Nightly/Firefox to send technical and interaction data to Mozilla. A message bar/info bar container should appear showing the "Learn more" link.
   • You'll need to replace this XUL label with moz-support-link. You can see some examples in Bug 1801927
   • If you have any problems with this bug, please comment on this bug and set the needinfo flag for me. Also, you can find me and my teammates on the #reusable-components channel on Element/Matrix most hours of most days.
4. Build your change with mach build and verify your changes. Also check your changes for adherence to our style guidelines by using mach lint.
5. Submit the patch (including an automated test, if applicable) for review. Mark me as a reviewer so I'll get an email to come look at your code.
   • How to Submit a Patch
   • This is when the bug will be assigned to you.
6. After a series of reviews and changes to your patch, I'll push it to autoland.
   • If there are changes requested, please read the "To update a submitted patch" section to ensure you don't accidentally create a duplicate revision!
   • Your code will soon be shipping to Firefox users worldwide!

Comment 1

[u723200]

Hi Tim, I want to help solve this bug. Plz explain what are the next steps.

Comment 2

[Tim Giles [:tgiles]]

Hi Raghav, I've gone ahead and assigned you the bug. I'd recommend you read comment #0 about getting started with the codebase, if you haven't worked with the Firefox codebase before. You'll need to replace the "telemetryDataDeletionLearnMore" XUL label with a <moz-support-link> component. You can use searchfox.org to easily search through the codebase and use the "telemetryDataDeletionLearnMore" ID to find where in the code this label lives. Additionally you can look at the phabricator patches attached to Bug 1801927 (such as this particular patch) for examples of previous elements that were replaced with <moz-support-link>.

Feel free to needinfo me on this bug (using the "Request information" section at the bottom of the bug) or reach out over on Element/Matrix.

Comment 3

[Raghav [:Raghav-Programmer]]

Hi Tim, I am really sorry, actually I disabled my previous account due to some mail issue....Plz reassign this issue to me....thanks!

Comment 4

[Raghav [:Raghav-Programmer]]

Ok now that I have been assigned this issue....I'll work on this and solve it asap.

Comment 5

[Raghav [:Raghav-Programmer]]

I tried to download the source code of Firefox using the steps given in "Bootstrap a copy of the Firefox source code" for my windows machine. It took a long long time and my laptop went to sleep in b/w due to which it got interrupted. I tried "hg recover" command then "hg verify" then "hg recover" again but it said "no interrupted transaction available".....What should I do?

Comment 6

[Tim Giles [:tgiles]]

:Raghav-Programmer, I would delete the corrupted repo and re-download and ensure your laptop does not go to sleep. Unfortunately the Firefox repo is relatively large and may take some time to download everything needed. I've never run into this particular issue before so I'm not sure what else to do in this case.

Comment 7

[Raghav [:Raghav-Programmer]]

I am still not whether it would work or not....but I'll try. If it doesn't work again...is there any other way I can contribute to firefox....maybe through GitHub repo or something?.....cause I really wanna contribute.

Comment 8

[Tim Giles [:tgiles]]

There are some GitHub repos we used for other kinds of contributions to Mozilla (repos I am unfamiliar with tbh), but Firefox development happens with the main repo that you are trying to download. Once you download the Firefox source code, you shouldn't have any issues with keeping the source code updated. It's just the initial download that can take a long time (there is over 20 years of commits that have to be downloaded and parsed and then there are a lot of files in Firefox!)

Comment 9

[Lata]

Hey! If this issue is available can I work on it?

Comment 10

[Tim Giles [:tgiles]]

:Raghav-Programmer, are you still running into issues with setting up the dev environment? You could try the Mercurial bundles approach which is better for slower or unstable network connections. Please let me know if you need more help or reach out over on https://chat.mozilla.org/#/room/#introduction:mozilla.org

Comment 11

[Lata]

Hey! Since the previous assignee is unavailable and I'm in search of a bug to solve. Can you please assign me this?

Comment 12

[Lata]

Hey, it looks like the previous assignee is not working on this bug. I'm interested in solving this bug. Currently, I'm working on a bug that is about to finish and I have time to devote to another bug. Since we are already in the middle of the timeline of the contribution period, I request you if this bug is still open please assign it to me. It would be totally fine if you want to keep it for someone new though.
Thank you.

Comment 13

[Tim Giles [:tgiles]]

Putting this bug back into the unassigned good-first-bugs list so another first time contributor can work on it.

Comment 14

[Ebilite Uchenna]

Hello Tim, can I work on this bug for my first time contribution as an outreachy applicant

Comment 15

[briannapatricia7]

hello Tim, can i work on this bug. I am an outreachy applicant. thanks always

Comment 16

[briannapatricia7]

tim, step three is not clear to me, any clarification

Comment 17

[Ebilite Uchenna]

Hello Tim, With respect to this bug, there happens to be a crash of understanding in general as how to approach point number 3. Can you please throw more light on that for better guidance

Comment 18

[Lata]

(In reply to Ebilite Uchenna from comment #17)

Hello Tim, With respect to this bug, there happens to be a crash of understanding in general as how to approach point number 3. Can you please throw more light on that for better guidance

Hey! You can get started with this bug by simply going in your nightly window and type about:preferences#privacy in the search bar. I'm attaching screenshot of nightly window for this. You will land to into the privacy and security menu of settings. There you have to navigate to "Nightly Data Collection and Use". There when you uncheck the "Allow Nightly/Firefox to send technical and interaction data to Mozilla. A message bar/info bar container will appear showing the "Learn more" link. Now you have to make the required changes in the source code as suggested in the next steps. You can see Bug 1801927 for reference also.
I hope this helped you to begin. Thanks.

Comment 19

[Lata]

Attachment: Nightly window

Comment 20

[Ebilite Uchenna]

Attachment: Bug 1820209 - Changed telemetryDataDeletionLearnMore in about:preferences#privacy with moz-support-link. r?tgiles

Comment 21

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/4fc76bd0c45d
Changed telemetryDataDeletionLearnMore in about:preferences#privacy with moz-support-link. r=tgiles

Comment 22

[Marian-Vasile Laza]

https://hg.mozilla.org/mozilla-central/rev/4fc76bd0c45d