1820244 - Link Previews have white text on off-white background with the Dark Theme enabled

Status: RESOLVED FIXED

(Thunderbird :: Theme, enhancement)

Description

[tiger.railgun]

Attachment: Link-Preview-Inconsistency-Write_ (no subject) - Thunderbird.png

User Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/110.0.0.0 Safari/537.36

Steps to reproduce:

First open Settings>>>Composition and make sure the checkbox is filled/checked beside "Add link previews when pasting URLs". Also make sure the Dark Theme is enabled.

Second, compose a new email and paste in a link/URL. (preferably a link that has text appearing with it also, some links don't have much text appearing with the preview.) With the dark theme, the link preview has white text on off-white background.

Actual results:

The title of the link on the link preview is black on white, though the rest of the text is unreadable without a very close examination.

Although when viewing the sent email, the text is actually black on a light gray background, so it's only when composing a new email that the text is white on an off-white background.

Expected results:

All of the text on the link previews should be readable when composing an email.

Comment 1

[Magnus Melin [:mkmelin]]

https://searchfox.org/comm-central/rev/00f669cd3407d8d07f58348ec9cb3a0a5221ae51/mail/components/compose/content/messengercompose.xhtml#2572,2576
I don't recall reasons for why colors were set.

Comment 2

[tiger.railgun]

Attachment: Link Previews Write_- Thunderbird.png

The link previews still have white text on white background, with the dark theme used.

Comment 3

[tiger.railgun]

Attachment: Link Preview-Write_Subject Line - Thunderbird.png

This inconvenience for the users when writing a message is still present on the current Windows 10 version, 115.4.2 (64-bit) with the default Dark Theme used/enabled.

Thank you.

Comment 4

[Richard Marti (:Paenglab)]

Attachment: Bug 1820244 - Remove the hard coded colors in link preview. r=#thunderbird-reviewers

Comment 5

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/comm-central/rev/ca767bf0e308
Remove the hard coded colors in link preview. r=mkmelin

Comment 6

[Richard Marti (:Paenglab)]

Comment on attachment 9363219 [details]
Bug 1820244 - Remove the hard coded colors in link preview. r=#thunderbird-reviewers

[Approval Request Comment]
User impact if declined: with dark themed messages some unreadable text in the link preview
Testing completed (on c-c, etc.): on c-c
Risk to taking this patch (and alternatives if risky): low

Comment 7

[Rob Lemley [:rjl]]

Comment on attachment 9363219 [details]
Bug 1820244 - Remove the hard coded colors in link preview. r=#thunderbird-reviewers

[Triage Comment]
Approved for beta

Comment 8

[Daniel Darnell [:dandarnell]]

Thunderbird 120.0b6:
https://hg.mozilla.org/releases/comm-beta/rev/0de55119ffaa

Comment 9

[Wayne Mery (:wsmwk)]

Comment on attachment 9363219 [details]
Bug 1820244 - Remove the hard coded colors in link preview. r=#thunderbird-reviewers

[Triage Comment]
Approved for esr115

Comment 10

[Rob Lemley [:rjl]]

Thunderbird 115.5.0:
https://hg.mozilla.org/releases/comm-esr115/rev/a0299f781da3