1820249 - Update the translation popup's icon to UX recommended treatment

Status: RESOLVED FIXED

(Firefox :: Translations, enhancement, P2)

Description

[Greg Tatum [:gregtatum]]

The UI will need to give an indication when the page is being translated. UX will have specific feedback on how this should work, but this bug will track that work.

Comment 1

[Greg Tatum [:gregtatum]]

I'm updating this bug to be about applying the specific UX feedback on the translations icon appearance and behavior.

Comment 2

[Greg Tatum [:gregtatum]]

Attachment: WIP: Bug 1820249 - Add the settings gear icon to the translations panel; r?nordzilla

Comment 3

[Greg Tatum [:gregtatum]]

Attachment: Bug 1820249 - Rework the mocks for language identification r?nordzilla!

This is part 1/3 of the mock rework, the tests are updated in a later
patch. This rework was needed to properly expose the RemoteSettings API
for testing the icon state.

Comment 4

[Greg Tatum [:gregtatum]]

Attachment: Bug 1820249 - Rework the mocks system for the translations engine; r?nordzilla!

This is part 2/3 of the mock rework. The tests are updated in the next
patch.

Depends on D178222

Comment 5

[Greg Tatum [:gregtatum]]

Attachment: Bug 1820249 - Update the tests for the new mocking system; r?nordzilla!

This fixes the tests for the mock changes.

Depends on D178223

Comment 6

[Greg Tatum [:gregtatum]]

Attachment: Bug 1820249 - Drive-by fix for an unhandled test error; r?nordzilla!

I am not sure if this behavior changed since this test was written, but
accessing the contentWindow throws an error now, rather than being
undefined. I updated the translations code to remove this error.

Depends on D178224

Comment 7

[Greg Tatum [:gregtatum]]

Attachment: Bug 1820249 - Apply UX feedback to translations icon; r?nordzilla!

This creates 3 icon states:

1. The translations offering with a single icon.
2. The loading icon with the spinner.
3. The live translation document, with the "translate to" locale listed.

Note that the locale text in the icon can grow to three letters in
theory, but in practice this does not happen with our currently
supported languages. I made sure the button can grow correctly if this
ever happens.

The tests are in the next patch.

Depends on D178225

Comment 8

[Greg Tatum [:gregtatum]]

Attachment: Bug 1820249 - Add tests for the translations button; r?nordzilla!

Depends on D178226

Comment 9

[Greg Tatum [:gregtatum]]

Attachment: Bug 1820249 - Split up test browser_about_translations.js; r?nordzilla!

Depends on D178227

Comment 10

[Greg Tatum [:gregtatum]]

Attachment: Bug 1820249 - Split up test browser_translations_panel.js; r?nordzilla!

Depends on D178448

Comment 11

[Phabricator Automation]

Comment on attachment 9334185 [details]
Bug 1820249 - Rework the mocks for language identification r?nordzilla!

Revision D178222 was moved to bug 1833906. Setting attachment 9334185 [details] to obsolete.

Comment 12

[Phabricator Automation]

Comment on attachment 9334186 [details]
Bug 1820249 - Rework the mocks system for the translations engine; r?nordzilla!

Revision D178223 was moved to bug 1833906. Setting attachment 9334186 [details] to obsolete.

Comment 13

[Phabricator Automation]

Comment on attachment 9334187 [details]
Bug 1820249 - Update the tests for the new mocking system; r?nordzilla!

Revision D178224 was moved to bug 1833906. Setting attachment 9334187 [details] to obsolete.

Comment 14

[Phabricator Automation]

Comment on attachment 9334188 [details]
Bug 1820249 - Drive-by fix for an unhandled test error; r?nordzilla!

Revision D178225 was moved to bug 1833906. Setting attachment 9334188 [details] to obsolete.

Comment 15

[Phabricator Automation]

Comment on attachment 9334837 [details]
Bug 1820249 - Split up test browser_about_translations.js; r?nordzilla!

Revision D178448 was moved to bug 1833906. Setting attachment 9334837 [details] to obsolete.

Comment 16

[Phabricator Automation]

Comment on attachment 9334842 [details]
Bug 1820249 - Split up test browser_translations_panel.js; r?nordzilla!

Revision D178452 was moved to bug 1833906. Setting attachment 9334842 [details] to obsolete.

Comment 17

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/6ff39297ab90
Apply UX feedback to translations icon; r=nordzilla,desktop-theme-reviewers,sfoster
https://hg.mozilla.org/integration/autoland/rev/53d0397ea5e9
Add tests for the translations button; r=nordzilla

Comment 18

[Norisz Fay [:noriszfay]]

https://hg.mozilla.org/mozilla-central/rev/6ff39297ab90
https://hg.mozilla.org/mozilla-central/rev/53d0397ea5e9