1833906 - Update the translation tests mocks to directly mock RemoteSettings

Status: RESOLVED FIXED

(Firefox :: Translations, task, P2)

Description

[Greg Tatum [:gregtatum]]

This will make things like Bug 1820249 testable, where the tests need to test the download behavior.

Comment 1

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/4a5ecd8c9eab
Rework the mocks for language identification r=nordzilla
https://hg.mozilla.org/integration/autoland/rev/860f3195b07f
Rework the mocks system for the translations engine; r=nordzilla
https://hg.mozilla.org/integration/autoland/rev/4b6db603e29d
Update the tests for the new mocking system; r=nordzilla
https://hg.mozilla.org/integration/autoland/rev/956e4235ca41
Drive-by fix for an unhandled test error; r=nordzilla
https://hg.mozilla.org/integration/autoland/rev/20af3d71d26b
Split up test browser_about_translations.js; r=nordzilla
https://hg.mozilla.org/integration/autoland/rev/273f32a0564f
Split up test browser_translations_panel.js; r=nordzilla

Comment 2

[Greg Tatum [:gregtatum]]

Attachment: Bug 1833906 - Rework the mocks for language identification r?nordzilla!

This is part 1/3 of the mock rework, the tests are updated in a later
patch. This rework was needed to properly expose the RemoteSettings API
for testing the icon state.

Comment 3

[Greg Tatum [:gregtatum]]

Attachment: Bug 1833906 - Rework the mocks system for the translations engine; r?nordzilla!

This is part 2/3 of the mock rework. The tests are updated in the next
patch.

Comment 4

[Greg Tatum [:gregtatum]]

Attachment: Bug 1833906 - Update the tests for the new mocking system; r?nordzilla!

This fixes the tests for the mock changes.

Comment 5

[Greg Tatum [:gregtatum]]

Attachment: Bug 1833906 - Drive-by fix for an unhandled test error; r?nordzilla!

I am not sure if this behavior changed since this test was written, but
accessing the contentWindow throws an error now, rather than being
undefined. I updated the translations code to remove this error.

Comment 6

[Greg Tatum [:gregtatum]]

Attachment: Bug 1833906 - Split up test browser_about_translations.js; r?nordzilla!

Comment 7

[Greg Tatum [:gregtatum]]

Attachment: Bug 1833906 - Split up test browser_translations_panel.js; r?nordzilla!

Comment 8

[Natalia Csoregi [:nataliaCs]]

https://hg.mozilla.org/mozilla-central/rev/4a5ecd8c9eab
https://hg.mozilla.org/mozilla-central/rev/860f3195b07f
https://hg.mozilla.org/mozilla-central/rev/4b6db603e29d
https://hg.mozilla.org/mozilla-central/rev/956e4235ca41
https://hg.mozilla.org/mozilla-central/rev/20af3d71d26b
https://hg.mozilla.org/mozilla-central/rev/273f32a0564f