1820356 - add birthday without the year - google carddav not accepting/saving it

Status: RESOLVED FIXED

(Thunderbird :: Address Book, defect)

Description

[Marco]

User Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:109.0) Gecko/20100101 Firefox/110.0

Steps to reproduce:

Searched in Thunderbird Google address book a contact and tried to add a birthday date without the year as is allowed on Google Contacts.
I leave the year field empty because I need add just the day and the mouth, i don't know the year.

Actual results:

Pressing the button to save the contact in Thunderbird never given any error but the birthday date that i add without inserting the year was not saved.

There is two BUGS issues:

1. Thunderbird address book never allow to insert a birthday date without the year when Google contact allow this
2. Leave the birthday year empty will cause no errors when the contact is saved but the contact is not saved or the birthday date added without a year is not saved. Thunderbird should not accept the save command without show an error if something is not saved.

Expected results:

Leave the year empty should save the birthday date without the year as allowed in Google. Thunderbird should allow to insert a birth date without a year.

Once pressing saving the inserted year date must be added and is very wrong that without any error the date is not saved because the year has been leave empty.

Comment 1

[Magnus Melin [:mkmelin]]

It's working fine for me. (Fixed in bug originally.)

Comment 2

[Marco]

(In reply to Magnus Melin [:mkmelin] from comment #1)

It's working fine for me. (Fixed in bug originally.)

I checked again and still be not working for me.
I open a Google contacts on the Thunderbird contact section, click on add special date birthday then select day and month, save and the birthday is not saved.

Comment 3

[Magnus Melin [:mkmelin]]

Oh I see what you mean now. The UI is working, but after trying to save to google, the change is removed.

Comment 4

[Marco]

Correct, is not saved.
Thanks.

Comment 5

[Laszlo M. Szabo[:Lacusch]]

I'm running into the same error/bug with the official Linux Flatpak version (at the time of writing Version 128.0.1esr)

I would be happy to work on / debug the issue by myself if somebody can give me any hints.

Comment 6

[Magnus Melin [:mkmelin]]

Attachment: Bug 1820356 - Send dates without a year to vCard 3.0 CardDAV servers with a placeholder year, so Google keeps them. r=#thunderbird-back-end-reviewers

vCard 3.0 can't express a date without a year, and Google silently drops a
BDAY like --04-15, so a birthday without a year was lost when the contact was
saved. Google does keep Apple's form, BDAY;X-APPLE-OMIT-YEAR=1604:1604-04-15,
as used by iOS and DAVx5, so use that for vCard 3.0 address books.

Google returns it as BDAY;VALUE=DATE,X-APPLE-OMIT-YEAR=1604:1604-04-15, which
loses the X-APPLE-OMIT-YEAR parameter when parsed, so the birthday showed as
1604, and the year 1604 was saved on the next upload. Fix up the parameters
before parsing.

Comment 7

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/comm-central/rev/f13ace180283
Send dates without a year to vCard 3.0 CardDAV servers with a placeholder year, so Google keeps them. r=babolivier